Re: [PATCH] gdb: make regcache's cooked_write_test selftest work with native-extended-gdbserver board

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2022-05-05 10:38, Pedro Alves wrote:
> On 2022-05-05 15:09, Simon Marchi via Gdb-patches wrote:
>> Running
>>
>>     $ make check TESTS="gdb.gdb/unittest.exp" RUNTESTFLAGS="--target_board=native-extended-gdbserver"
>>
>> I get some failures:
>>
>>     Running selftest regcache::cooked_write_test::i386.^M
>>     Self test failed: target already pushed^M
>>     Running selftest regcache::cooked_write_test::i386:intel.^M
>>     Self test failed: target already pushed^M
>>     Running selftest regcache::cooked_write_test::i386:x64-32.^M
>>     Self test failed: target already pushed^M
>>     Running selftest regcache::cooked_write_test::i386:x64-32:intel.^M
>>     Self test failed: target already pushed^M
>>     Running selftest regcache::cooked_write_test::i386:x86-64.^M
>>     Self test failed: target already pushed^M
>>     Running selftest regcache::cooked_write_test::i386:x86-64:intel.^M
>>     Self test failed: target already pushed^M
>>     Running selftest regcache::cooked_write_test::i8086.^M
>>     Self test failed: target already pushed^M
>>
>> This is because the native-extended-gdbserver automatically connects GDB
>> to a GDBserver on startup, and therefore pushes a remote target on the
>> initial inferior.  cooked_write_test is currently written in a way that
>> errors out if the current inferior has a process_stratum_target pushed.
>>
>> Rewrite it to use scoped_mock_context, so it doesn't depend on the
>> current inferior (the current one upon entering the function).
>>
>> Change-Id: I0357f989eacbdecc4bf88b043754451b476052ad
> 
> OK.

Pushed, thanks.

Simon