From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107511 invoked by alias); 18 Jan 2017 15:18:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107501 invoked by uid 89); 18 Jan 2017 15:18:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=HX-PHP-Originating-Script:rcube.php, H*u:1.2.3, H*UA:1.2.3, H*i:sk:7030895 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Jan 2017 15:18:44 +0000 Received: by simark.ca (Postfix, from userid 33) id 0FF731E16A; Wed, 18 Jan 2017 10:18:43 -0500 (EST) To: Luis Machado Subject: Re: [PATCH 1/6] New function null_stream X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 18 Jan 2017 15:18:00 -0000 From: Simon Marchi Cc: Yao Qi , gdb-patches@sourceware.org In-Reply-To: <70308951-95e4-a628-0a71-1526f2963640@codesourcery.com> References: <1484051178-16013-1-git-send-email-yao.qi@linaro.org> <1484560977-8693-1-git-send-email-yao.qi@linaro.org> <1484560977-8693-2-git-send-email-yao.qi@linaro.org> <20170118144506.GM28060@E107787-LIN> <79d15965-fd1c-5cff-54f1-d6b7d2e6b884@codesourcery.com> <2b52597c046b688cca11d55ac12cfb04@polymtl.ca> <70308951-95e4-a628-0a71-1526f2963640@codesourcery.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.3 X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00347.txt.bz2 On 2017-01-18 10:01, Luis Machado wrote: > On 01/18/2017 08:57 AM, Simon Marchi wrote: >> On 2017-01-18 09:53, Luis Machado wrote: >>> We're setting stream to NULL at the top of the function and then >>> checking if it is NULL (it obviously is) right after that? Am i >>> missing something? >> >> The "static" :). > > Oh, that's what i was missing! > > Can't we have a clearer way of reusing this stream? It looks cryptic > this way (at least i think it looks cryptic). With Pedro's ui_file c++ification series, there is a null_file specialization of ui_file, and it's just a global object that you can reference. Search for "null_file null_stream" in https://sourceware.org/ml/gdb-patches/2017-01/msg00312.html