From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/dwarf2: short-circuit cooked_index_entry::compare on identical strings
Date: Wed, 28 Oct 2026 13:21:24 -0400 [thread overview]
Message-ID: <b6553db7-005e-4481-b866-587d779ef58d@simark.ca> (raw)
In-Reply-To: <87ik2lpzml.fsf@tromey.com>
On 10/28/26 12:18 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> When asked to compare a string pointer with itself, we don't need to do any
> Simon> work, we know they are equal. Return 0 right away when both pointers are
> Simon> equal.
>
> Ok.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
Pushed, thanks.
Simon
prev parent reply other threads:[~2026-10-28 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 20:47 Simon Marchi
2026-10-28 16:18 ` Tom Tromey
2026-10-28 17:21 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6553db7-005e-4481-b866-587d779ef58d@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox