From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42643 invoked by alias); 10 May 2019 10:42:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42622 invoked by uid 89); 10 May 2019 10:42:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-12.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=here.=c2, HX-Languages-Length:2306, HTo:U*simark, HContent-Transfer-Encoding:8bit?= X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 10 May 2019 10:41:59 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 216B4AECD; Fri, 10 May 2019 10:41:57 +0000 (UTC) Subject: --disable-gdbmi build broken To: Simon Marchi , Simon Marchi , Eli Zaretskii Cc: "gdb-patches@sourceware.org" References: <20190118195659.23335-1-simon.marchi@ericsson.com> <83y37hbpwj.fsf@gnu.org> <44a5cfcc-d98e-fd14-ff47-755e218d76d0@ericsson.com> <5c79a173-d2eb-3e84-5d73-d52b0ec5fe17@simark.ca> From: Tom de Vries Message-ID: Date: Fri, 10 May 2019 10:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <5c79a173-d2eb-3e84-5d73-d52b0ec5fe17@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2019-05/txt/msg00246.txt.bz2 [ was: Re: [PATCH v2] Fix MI output for multi-location breakpoints ] On 13-03-19 20:16, Simon Marchi wrote: > On 2019-01-21 12:09 p.m., Simon Marchi wrote: >> On 2019-01-18 4:46 p.m., Eli Zaretskii wrote: >>>> From: Simon Marchi >>>> CC: Simon Marchi >>>> Date: Fri, 18 Jan 2019 19:57:11 +0000 >>>> >>>> +The following commands can be used to selectively enable behaviors >>>> from a >>>> +newer MI version.  They can be useful if you want to take advantage >>>> of feature >>>> +or bug fix only available in a more recent MI version than what you >>>> are using, >>>> +but can't yet migrate to that version for some reason. >>>> + >>>> +@table @code >>>> + >>>> +@item -fix-multi-location-breakpoint-output >>>> +Use the output for multi-location breakpoints which was introduced >>>> by MI 3. >>>> +This has no effect when using MI version 3 or later. >>> >>> I needed to read this text and the one in NEWS several times before I >>> figured out what is meant here.  How about this alternative instead: >>> >>>    If your front end cannot yet migrate to a more recent version of the >>>    MI protocol, you can nevertheless selectively enable specific >>> features >>>    available in those recent MI versions, using the following commands: >>> >>>    @table @code >>> >>>    @item -fix-multi-location-breakpoint-output >>>    Use the output for multi-location breakpoints which was introduced by >>>    MI 3, even when using MI versions 2 or 1.  This command has no >>>    effect when using MI version 3 or later. >>> >>>    @end @table >> >> Thanks, I adopted this wording. >> >>> Otherwise, the documentation parts are OK. >> >> Thanks for the reviews. >> >> I am still open to comments about the code parts.  In any case, the >> patch will >> remain up for review at least until the GDB 8.3 branch is created. >> >> Simon >> >> > > This is now pushed. > Hi, this change breaks the --disable-gdbmi build: ... ld: breakpoint.o: in function `print_one_breakpoint(breakpoint*, bp_location**, int)': src/gdb/breakpoint.c:6365: undefined reference to `mi_multi_location_breakpoint_output_fixed(ui_out*)' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:1893: gdb] Fout 1 ... Thanks, - Tom