From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iThOATVjmGq/Tx8AWB0awg (envelope-from ) for ; Wed, 02 Sep 2026 13:56:05 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NSTlQQeW; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=C9ThGKVo; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Y742TVlX; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pIAQhVIa; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E60191E166; Wed, 02 Sep 2026 13:56:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C86581E033 for ; Wed, 02 Sep 2026 13:56:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2432E4BA901A for ; Wed, 2 Sep 2026 17:56:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2432E4BA901A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NSTlQQeW; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=C9ThGKVo; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Y742TVlX; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pIAQhVIa Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 8FD8D4BA23E8 for ; Wed, 2 Sep 2026 17:55:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8FD8D4BA23E8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8FD8D4BA23E8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788371738; cv=none; b=Y+CG4DeWoX5GNs8F/bAueJGvUdHS2/RdC3IYKoP9HvVuguhrEmtphyWqi9JyPoYzRF3+1d/H1guidpzmdBqaA6PL7ArvTI9ztazJuYfN/ieNcNzciDnrDKL0SoTGH3bQwslFkJB02vbbusue+XOMGgYi9lYlfso9BsnNvPDr0Ak= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788371738; c=relaxed/simple; bh=zUCdFvFv8Kk6XB3kU+0b1kDRS/FtYZzbXUzt5TAbwVA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=YkQqL155SnnkAgnXyAPzgRAi4JCqZV4rjM2s3ADOoGcbwnYmY+nZ71LkwElpNd6OqJsPQDeITakMDDTp2iALllmpEev2gIkZuS7EYWebze9Ay9dL4jTTxiizgsRPK4dOjCS10rIh8p1qpLpK/G6IqfwTbvU+DY2aL7YyPQ58tTs= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NSTlQQeW; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=C9ThGKVo; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Y742TVlX; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pIAQhVIa DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FD8D4BA23E8 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6779F21CEB; Wed, 2 Sep 2026 17:55:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788371733; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WOXPAd8Xuo1aKpnQXUvvqvqGimAtW3BhcBqNkxbBepA=; b=NSTlQQeWa6dJhBQ4nFO61pjzCr5FHuam0p4SR8C3cm8VB2fEjZ7RkYNhuCRWSzTpufhPHx /7Cqd51y/MkSCsaUBNTqCOX/7Z1SUMhH8+FzcQfg4xM+HbxLgpT57kukmNKACXWZTmuyJo DNcP5CD55gNViuJxinAthDHJ8ckB9P4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788371733; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WOXPAd8Xuo1aKpnQXUvvqvqGimAtW3BhcBqNkxbBepA=; b=C9ThGKVoXN5jDFnA3uNR7DzVhq7pxDEGUARB8qAJpc7enJb+cy0sRaNulbdPMWPNvaOF23 95b8mbyHHtnRk2Dg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788371729; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WOXPAd8Xuo1aKpnQXUvvqvqGimAtW3BhcBqNkxbBepA=; b=Y742TVlX0mv09WgF+i/+gT6fQk4IxNTQUC7953chdRGTOnUOcaidcX8eNchGCi/GC3cCYv jKZ5HEKLKBItth36FmfY+Mjxjur11zm5WQIxpD7dcu5InmWEbwf841yzlLmxXL+kFxrNTR J/FONkegYGIbpaYhz4Z7JMJ0wof1H7g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788371729; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WOXPAd8Xuo1aKpnQXUvvqvqGimAtW3BhcBqNkxbBepA=; b=pIAQhVIa53xVyvRMO+/72PywWMreTIFn5nLF0WliPNzasgCsaarrNEYYFbaQP3+fAr/He9 +BX5hyut6+78KQCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3892613515; Wed, 2 Sep 2026 17:55:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wXxrDBFjmGrLZQAAD6G6ig (envelope-from ); Wed, 02 Sep 2026 17:55:29 +0000 Message-ID: Date: Wed, 2 Sep 2026 19:55:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Boolify gdbserver_windows_process::child_initialization_done To: Tom Tromey , gdb-patches@sourceware.org References: <20260902163611.3526083-1-tromey@adacore.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260902163611.3526083-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email, suse.de:mid, imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/2/26 6:36 PM, Tom Tromey wrote: > This changes gdbserver_windows_process::child_initialization_done to > be a boolean. LGTM. Approved-By: Tom de Vries Thanks, - Tom > --- > gdbserver/win32-low.cc | 4 ++-- > gdbserver/win32-low.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc > index 13c14a7c69f..2cb5ab5d170 100644 > --- a/gdbserver/win32-low.cc > +++ b/gdbserver/win32-low.cc > @@ -317,7 +317,7 @@ do_initial_child_stuff (HANDLE proch, DWORD pid, int attached) > > proc = add_process (pid, attached); > child_init_thread_list (); > - windows_process.child_initialization_done = 0; > + windows_process.child_initialization_done = false; > > if (the_low_target.initial_stuff != NULL) > (*the_low_target.initial_stuff) (proc); > @@ -373,7 +373,7 @@ do_initial_child_stuff (HANDLE proch, DWORD pid, int attached) > = inferior_started_by_cygwin (pid, attached); > #endif > > - windows_process.child_initialization_done = 1; > + windows_process.child_initialization_done = true; > } > > /* Resume all artificially suspended threads if we are continuing > diff --git a/gdbserver/win32-low.h b/gdbserver/win32-low.h > index 439adb84bc2..443af62c9c7 100644 > --- a/gdbserver/win32-low.h > +++ b/gdbserver/win32-low.h > @@ -197,9 +197,9 @@ struct gdbserver_windows_process : public windows_nat::windows_process_info > /* True if current_process_handle needs to be closed. */ > bool open_process_used = false; > > - /* Zero during the child initialization phase, and nonzero > + /* False during the child initialization phase, and true > otherwise. */ > - int child_initialization_done = 0; > + bool child_initialization_done = false; > }; > > /* The sole Windows process. */ > > base-commit: 49c379f8c2f8ff888b621b4a070dc1976b942577