From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55085 invoked by alias); 16 Sep 2018 03:20:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55067 invoked by uid 89); 16 Sep 2018 03:20:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Sep 2018 03:20:30 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 952CB1E186; Sat, 15 Sep 2018 23:20:28 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1537068028; bh=PDj8Ir4o+Wb5jwDtwK56Lktpx1AC74fFOuiWTlH8D2Y=; h=Subject:To:References:From:Date:In-Reply-To:From; b=s0CaUH3E7HLqxDgRy4a+Bhd3Juqitiab36G/Gt652LkXkohufyyBqI9/PbEBbWhVo L67TdccrLd7Ez5ipCyEMr2DWxH+o107SAJ/5YqiTFWTj+acjXEy36HJyYf+iK3npfn ygatbzk3Z6W0tMaPwhgJ7BNC7tzEoXGeE5LvqjNE= Subject: Re: [PATCH 2/3] Use GNU style for metasyntactic variables in gdb To: Tom Tromey , gdb-patches@sourceware.org References: <20180915025522.18723-1-tom@tromey.com> <20180915025522.18723-3-tom@tromey.com> From: Simon Marchi Message-ID: Date: Sun, 16 Sep 2018 03:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180915025522.18723-3-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg00523.txt.bz2 On 2018-09-14 10:55 p.m., Tom Tromey wrote: > I searched for other spots that did not use the GNU style for > metasyntactic syntactic variables. This patch fixes most of the ones > I found in gdb proper. There are a few remaining in MI, but I was > unsure whether those should be touched. About MI, I don't see why it should be different. Do you have specific examples? I stumbled on some messages like this: error (_("-environment-cd: Usage DIRECTORY")); That looks confusing to me, I would much prefer error (_("Usage: -environment-cd DIRECTORY")); Simon