From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ofhqB4DXU2i6ZRQAWB0awg (envelope-from ) for ; Thu, 19 Jun 2025 05:25:20 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Zjf3njX7; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Zjf3njX7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 07FCF1E11C; Thu, 19 Jun 2025 05:25:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B5AF21E0C2 for ; Thu, 19 Jun 2025 05:25:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A61C03866210 for ; Thu, 19 Jun 2025 09:25:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A61C03866210 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Zjf3njX7; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Zjf3njX7 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c200::3]) by sourceware.org (Postfix) with ESMTPS id A8393384FAFB for ; Thu, 19 Jun 2025 09:24:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A8393384FAFB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A8393384FAFB Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c200::3 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1750325074; cv=pass; b=HPJG+1l66sE7foOoOIDRbDaDzcXmFNniQ7god5TFECk87oUc7yxbzqQsi7qA5qV+TIh9GvYf8muJsyEfJDm5fHp5RkvUMaK1DZwnUS/frphAM/dHkDkqNA81fASd2v6QopxxkK1cdwqQRlxJkmdcbecYoc94GKIBVO2xUynb628= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1750325074; c=relaxed/simple; bh=Y6nAXoJtWM2poLj7YRm3KFJ0zs0w//faYufVOEPDNW4=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:From:Subject:To: MIME-Version; b=Dzheq1UEQRC7KLlppSvI90QKwX+UrwaOttSX8p4cJdT08+Zw5pFoZ5hI5zGl3X3jlPkpee764S40qfIWee3JCBBrnVNBlQWh5U0NOKEolKLjFVdm1C3c5Iamk5QOnDfxe7odEPrpwzQshR1+FikU9zJHlPYxOchh3e4KCBQX2cc= ARC-Authentication-Results: i=3; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A8393384FAFB ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=oZkWlLMNYLwpTfI6YaaigV1SU9SqD+v+ksgs0Pye2iR4pBvbuoF9MWbbhFsPQ89+CA1yLJj7GrUyKjiWhlJoEZIxa2/JZQ0WY/vPa1aO/Uc7suBIi37/T7YaFacACw3QdUpv+0fFj+9HfOCCnhJdY/clqfSdbL+fPN6WnIjnLcwWFFSqFhMFMZCgPx8lwv0/d/RiItz4iYR6NUwpceaN65WLytqr7wx9J1/1IfMK4ekAoDas1vNGVRgFtU3olu0uMewlfEMwnhGILIn/bfdPtOSjRrgBvXag8crQlMlqJgvNhCRI5DfXJ4GXMsLiE2Nfb+GIblMYadyxbxaNH6EO/w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vx6Yr/lAjRuwwVzx7rvD/9G4wkBc6t5rhfzaUzU7yxc=; b=DpX2nlpqsb80BNM7u/n0WEmnyFNXjBfqjo7UbrIHjuITbtaL74G+6k67xPzW1KAsZK7+5G/yZfqYKEYwWrL6sOjFxDe5PHDne07Qi3o/ESzLCwk7CnWxNI0mJBHeLYuyRRVwDzRm+hFgWkVPqlu68MOwDcf4jV4t9xSHwODgbABWqWfAx6lVsa5w25FFk2zkLrD+lWo6rXgQecBK8bKv0MmXNtpThXNsAPntu5I2HSuAkpOBMhTzgd9VPYbZMZb6wFAWn4LJMvydqEee26CapJSDqjbVeZr8qi7/Qs1rfcSZxBH8vjtXHm6lCxwjKHqUjpynTejpEYatJJWvolLqCw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=intel.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vx6Yr/lAjRuwwVzx7rvD/9G4wkBc6t5rhfzaUzU7yxc=; b=Zjf3njX7y2ZhghWhgi7fZWa/CKwWVsNkukA1miOBMnC8h/Obm6lezMjQOjd8AD95dgD1txJ5JUa1uRHzBrJSOacH8C6Niv4FGgoU4te6EVoljBOqn3kmLEsBPrWCk5NUpKTmkwDNUk5KtD214Cj7QMzB/sMjStHMLw8n/ScR9Eg= Received: from AS4PR10CA0017.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:5d8::7) by DBAPR08MB5640.eurprd08.prod.outlook.com (2603:10a6:10:1a3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.20; Thu, 19 Jun 2025 09:24:32 +0000 Received: from AM2PEPF0001C70E.eurprd05.prod.outlook.com (2603:10a6:20b:5d8:cafe::a1) by AS4PR10CA0017.outlook.office365.com (2603:10a6:20b:5d8::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8835.35 via Frontend Transport; Thu, 19 Jun 2025 09:24:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AM2PEPF0001C70E.mail.protection.outlook.com (10.167.16.202) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8857.21 via Frontend Transport; Thu, 19 Jun 2025 09:24:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yuIOfLM4AbZ2JfGj1lS/HB2SfdsW5Q2h6b4IwSgwPhpeFDlFuM4RK77wAfjwUlLSs5AppL+KsLTIj0Kj05HUrV5g6WmYkiukDWMTgCmORds2gWpV1gMS/3kPhs5KWSe4L+GJpoaApCp8qFxJezXBa8DKxHJzaBIQmE5rnEJFW1PW3uKjOGIq4W/+ssVtVlaMay6vY84qXZOdqQQyNo5I0cKJbbsC8jraF6xv3j+y2l9BBlIbQsA2HlOLuUP5COj5Hfe04vwusyTxINPL99J2Tlfif/NNeyggrctCd1/OdCplkZnu2KUSuUHliL/w+S6Lg17bhOpSMxsG82aQq9Rscw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vx6Yr/lAjRuwwVzx7rvD/9G4wkBc6t5rhfzaUzU7yxc=; b=VVau3WXMV7r+kUrHm2+G2RrdxB1HZsxqk0HUOpDiPh1SiWU4tG/RIgbjkXg0nXIxZ0Sob9LEVPgsnBrcRndOdodl/qEdRM5haMUGVWS6wendmv7V5aW1tCP47HX0jjCUkG8OSm9E2p7y4MwUTuwPI2cuwQGgCA39bdm9B9u1EiY4ugkeQ7iQi7Rh4Kt0QE0PT69pCL3w/ySluxxeJRWrwilH6rkvcyCvuSXyou5GU6xUfLDry95Ee75l3W17KcO+gQheuujDrbz5CmtlwrI9Ugr2sqcDAph4TUx/szmWYov21xjoCzSwCw7nRHbO84GG+Wrg23ejURGBQ87LQBBdRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vx6Yr/lAjRuwwVzx7rvD/9G4wkBc6t5rhfzaUzU7yxc=; b=Zjf3njX7y2ZhghWhgi7fZWa/CKwWVsNkukA1miOBMnC8h/Obm6lezMjQOjd8AD95dgD1txJ5JUa1uRHzBrJSOacH8C6Niv4FGgoU4te6EVoljBOqn3kmLEsBPrWCk5NUpKTmkwDNUk5KtD214Cj7QMzB/sMjStHMLw8n/ScR9Eg= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) by DB3PR08MB8940.eurprd08.prod.outlook.com (2603:10a6:10:431::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.30; Thu, 19 Jun 2025 09:23:58 +0000 Received: from PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d]) by PR3PR08MB5852.eurprd08.prod.outlook.com ([fe80::f44:d113:1c29:825d%6]) with mapi id 15.20.8857.019; Thu, 19 Jun 2025 09:23:57 +0000 Message-ID: Date: Thu, 19 Jun 2025 10:23:49 +0100 User-Agent: Mozilla Thunderbird From: Luis Machado Subject: Re: [PATCH v4 04/11] gdb, gdbserver: Use xstate_bv for target description creation on x86. To: Christina Schimpe , gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org, eliz@gnu.org References: <20250617121147.1956686-1-christina.schimpe@intel.com> <20250617121147.1956686-5-christina.schimpe@intel.com> Content-Language: en-US In-Reply-To: <20250617121147.1956686-5-christina.schimpe@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: JNXP275CA0047.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:18::35) To PR3PR08MB5852.eurprd08.prod.outlook.com (2603:10a6:102:8e::21) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PR3PR08MB5852:EE_|DB3PR08MB8940:EE_|AM2PEPF0001C70E:EE_|DBAPR08MB5640:EE_ X-MS-Office365-Filtering-Correlation-Id: 27e6a624-6f7d-4c15-66e0-08ddaf131905 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|376014|366016|1800799024; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?UFVWNWQvNHpBZ3BoWXdULzVnazNnZHFYR2swUExTc2oxL0c1WmFYbzNNTTVM?= =?utf-8?B?N1k3aEV5RXAvZTdYbDJlYzBuVWVNUVlJdWY1eGRrNlBscEN3clIyZ2tBQTND?= =?utf-8?B?S1k3MDFQZnJIZkFwdUkzZS9MandHZlN2UGZEZVd2c21qK0NCTGdGNG92SStX?= =?utf-8?B?c0NYVzFYRnNJVERmcEVzNjhUcjJLUXZuNUtLUEw2Rm0weXJpMkZGck5SZktw?= =?utf-8?B?MmU2MTBHeHdIeGM3dFg3K2tXNmpPU3pCdEVvTmJCelRDT1VFWU9DV0V6WlRy?= =?utf-8?B?Y2xheEdWTlhKMFFLZ2ZZaGZJb1czMVpEbkNGU1NsekFjZGZkMDZSMktNVkRx?= =?utf-8?B?cXYvdGt1VStIWnRpc25YdEZzVEZaVmFjd2laUWtiMkNrcFliS1JnM2Vtemlw?= =?utf-8?B?bDJsMTE0S2VwNTRrWDZVMG8yRlNCQWhMTW9qemoraDBHVlN0U1RQcnhTN0p6?= =?utf-8?B?WmNydUhQazkzL09KdWdUemZIaTQrTDJEcmg2V1k1ckE2MVBGRVBkdlRDUTRl?= =?utf-8?B?QnZJdlpNK3FVWVZrNjcyc1JETStuNDFUMTJHNVFxNXhRNWhpcldtRENtQ0pW?= =?utf-8?B?MlAzZzV4UWVpczUrWDhQalhPeDJUUmJSclJpTFhvc1doWm9UdzlEalVxWVdy?= =?utf-8?B?eDM0YmRvNUpjWC9MMDJpRDEyVTJrS1h3enpPWnp3WkxGeXhPNVJ0akVvSUJV?= =?utf-8?B?dXZMWisydlVncnZnWjhSU1FkMXl3VFVGVzc3UWh0U2hmN0xoZHpBNWlwbUIx?= =?utf-8?B?Z00rdW9JRVAwK21CR0haSGM4anhZR1oxSGI3LzZkZkgxYmpxemRRZ3hIa3Zt?= =?utf-8?B?c05KZkN6QzkxK1F5azYvMDlXWkNGSG1Ya2dOUElFMzJjT1NDcnpybWpTNVJG?= =?utf-8?B?ajRPaEtIbFFPTlVBSHJUbFpsa20yUml1WVpMNGw5U1pubFVJekR0b3VqZ09y?= =?utf-8?B?TXdTYWNiTlVWTXAwbkdINElFdjBxNmltNEJVd2tSZmUrQlprYWJiZnJMMlFW?= =?utf-8?B?amNxaVZMdnd6VWg1NFkrNE1FNGU1cDFPRlp5OUQ2ZWtkWTVoVTJyQVpaMnNh?= =?utf-8?B?cmRuMHZ2UloyOUVDczBWY3k4eTEvaDVDZUtSM2ZTakxYZGx1RG85UUJFYlRR?= =?utf-8?B?NXkrQU9nWGxoVklmK1o2L0FJekxNNlF5WGhQdkRWbHRLd3N5bUJGZjB6UjhG?= =?utf-8?B?RkExSEsycWkyQzFSQzd1UHBJWTlDVVBqRzNhdjJlNi9aVGYxTFNqS2YwaDBi?= =?utf-8?B?TytWVGtwaUxFNk1JMWYrdVp4QnFzbSt5elFMUHdkbnlFM0M4cXh5U0h2ZUZ3?= =?utf-8?B?alRmZTkwR3hMMGJUazRYbUZvTHJtUUtrTEd4K1JML3UrQkFTTUMrUWhaTlpO?= =?utf-8?B?T1YvSHFFSE8vcXAzYmtxMVpha0F4WGVKR2RST2ZTbkI4alRUblRicGlYdmFB?= =?utf-8?B?c2Q4Wk8zMm0reVA0TlhRei9Ubjc5Z3lTQ2xpQkVHNHJSN1lpL3lWV3JvajB0?= =?utf-8?B?UXFhK21PVWwwWmZQV1Y4V0gySERlUGFLTGhIRncyOGpTNnFYQ2craEdISXJJ?= =?utf-8?B?dlgrVUppZ0F1S09wQ2VSelJmTHlnWFR3YzZOLzM2djFGNkdzMFpqbDFhNyt6?= =?utf-8?B?eGZrYU5kNUxZczM5b29EMXhlZGhxRCtMMHdib3g0QWVsRUVMY0Q5QUhJbWFL?= =?utf-8?B?TGc3V3QyWldiZk5qMTJPWElyN2dPNVhNcVJtdm95OVlmWmUwbXdTQXFtaTAx?= =?utf-8?B?T2g3MmtwcmdHUFhtZHFQU2grZHBwbjdmS0dPcEFGNXcrZ1JsRmI5elFlVXhr?= =?utf-8?B?TGxEc3NrVktXbU9UVnphQUR0TXVHRkE2NXp4b0dNQVZCUW5lUHN1Z1hnMlYz?= =?utf-8?B?T3lraUU0Z2hWYlZoOHkxOVhRSEd6Tkg5S2FJbkpZVko0Ykw0cUFQZzVuZW5x?= =?utf-8?Q?IMXlaFQHJD8=3D?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR08MB5852.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB8940 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM2PEPF0001C70E.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 65148aa2-17c3-4603-7977-08ddaf130496 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|36860700013|14060799003|1800799024|35042699022; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Yk50Vm1KYmNtQUNCSno5eEZ6S25MRnRRZ0l6TWZVK2NHM05FVzQySDBHQ3E5?= =?utf-8?B?NGxqNjJwWEtJRDY2T1pOZXpkajdWbmEzN2g4dnVyODl5UUxScXNORUVSbnYw?= =?utf-8?B?S1Arek9Ua3NvS1o5NWRZejFEUFJqWGdwSXFxRlBkUEYrd243NnhCLy9LR3Z0?= =?utf-8?B?T1RidGhjKzJMUDFMWVQ0NW1tVE5nNzBjekpHVUZacEtoYm55QnVXaFFybW5z?= =?utf-8?B?REhudWJ3aUtYc1BtUEdPVzVwTVdhQlY4T0p4N0JQbjhZZjdFb05HZ2xNMkd6?= =?utf-8?B?YlUyWStVWUZ6Z3kwbGhBWmFYanZDbDkxY1lBazA3RTFuZDFSLzV4TWd2S0hr?= =?utf-8?B?MStQL1FkWFdKcTZIcUUxcDBsN0RkMUNqSStFVmNZbEJZTGlybVlGbzFWTE80?= =?utf-8?B?bUVzVUFjY2RWb2IwQUtDUjZEMGhyYm5FMUI2eFp5Sk8xczNQdDJ6Z0FMS3lX?= =?utf-8?B?N3JZUDltVXpPQTEveGhld0RLQnQzYUNrOEI5RTEyWjh6Q3BTVWVCSEhmdm5T?= =?utf-8?B?aE8yd1dMSXZOM3ByVGlnNi94ZmlMek82ZEsra1B0K0lRSUZabTRnNTliRjVF?= =?utf-8?B?UDRWM2cwS2UvZEl1N3pYeUphZnhsY1BwalBZVWF2Z0VGRlg1Nzc0ZXl1d1ZC?= =?utf-8?B?Q2E2RVFpeElJeTNtdEpLTUxsOGJxd0xvZHlrQTlXa0J4akNBdnZwbkkydEtD?= =?utf-8?B?cm4rTkU0MlcyZDl6L2JmTG53L2NVV2VmRE1NbDQrNTdZaUE4MWMvM0g2Z3I4?= =?utf-8?B?ajQyQ0RLTmF2YlFVVjM1NU9jbnM0ZmFoVEZ4bCt1ZCtIQlRCZVY3eFdxK2pK?= =?utf-8?B?Y0RyaDFScUw5RHJXQXRtTm9BTjBlYktYMS9zMWxjVHRuWEV3eEh0dmFlN09H?= =?utf-8?B?TGRKZUsrYVZBRXBXcWlBVHI2L245MkNFbDFZYU8xL0dwakVUMU9KVmpEWW1m?= =?utf-8?B?MVB4N1NnSFhsRDhaWUtZY1lmcmNvaHVLUXRDK0VBQnN3eCtFdGZZQ2IrOVRa?= =?utf-8?B?dStqR21EVjdIM1lHZEZzMTU3SEszcTlLNytuUWpCcnlnREllajMxeFU0c0NT?= =?utf-8?B?andHN1VXNkVZNTd5UGpwaUpCOWpZdWxlcTB5cnRZYTgzNXIvanZnVkY1OEVm?= =?utf-8?B?VkRUc2hQZzc3NENSaWtBTVBlYVNxQVlZRTdXazhYTU1QK200eUFneGJKVEFL?= =?utf-8?B?TlROZkE1R0pDT05POWZ1TUR5amZmcks0SzVFemx2amlBTno0NVpYQzduVXdG?= =?utf-8?B?a252RllhMUpyMDAzam9JOTN0UU1DakszaklqSU1vQkd5YTBRWGtpMzF3MC9M?= =?utf-8?B?Y1BMSlpLSWhFUkpjbWJKWERSVGZCM2RWUFVaN0thKzVwdUZ0TnVyRmhJbGF4?= =?utf-8?B?MlNsRzhiK2hXdXY1a2dtU09Vb0hHaUc4YUNmNDAwaUFhU1dKTTZtVngxSXkw?= =?utf-8?B?WUp4bWw0OEVpdHg5eTlHaTNoV1hnbmlEL3FCS0V5Nm1mMzJnZTM5bVFNalR1?= =?utf-8?B?NWcxdjhCWjFwYWpyN3d3aTgxeE5Gb0N4UG5LWG40WVc2QUxuZ2dqOXhoc1hD?= =?utf-8?B?VWF6bUtoalBKbFRsSkQ1TXVoOEQ2bFh1YXFnZTNDeHN1eFJkR0pjNlQxRTd0?= =?utf-8?B?cUh1RnUrU3NtY3d6cmF1djcxdDdCNHd0Tk53Ky9KZ21xVVNIYU1zQkVuallz?= =?utf-8?B?MlM4TW8xRzcwc3lkMmNRdXk4MEVFaWR0MzBOSFNKTFpSeU9DN1RNYzhFWkt5?= =?utf-8?B?RnljK3JlTXdPd2t0V09KNjRES1VtbUZyRXZCc3Q2NUtjTlFwL1NOOWQ0aU9m?= =?utf-8?B?SGV0dWJCYW10QUlJeURHR0RkY3Fyam1aeVN6YW9zSkVlaUVpR1ZMVStFYWN3?= =?utf-8?B?SlVzQjEzOHhjYzlkLzZja0owOFYrOUUxN1o2OFdMSkt6QzA0ZS9jRUlvQ0Qr?= =?utf-8?B?dHhoMlRvQ2xZTUdLaU5NTlVEUEx6alYrWXFJRXNZb1A4Vkh6MHBnRXJkYUUz?= =?utf-8?B?d1RYTWlGNDVFNnlVeHRjOG5TcU9jSEZZcUtVZWlaSnl3ZXFucFJ0Ym9JVG80?= =?utf-8?Q?yG9Owi?= X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(82310400026)(376014)(36860700013)(14060799003)(1800799024)(35042699022); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2025 09:24:31.4504 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 27e6a624-6f7d-4c15-66e0-08ddaf131905 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AM2PEPF0001C70E.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5640 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/17/25 13:11, Christina Schimpe wrote: > diff --git a/gdb/arch/amd64.c b/gdb/arch/amd64.c > index 252650b6390..9cac0645cdc 100644 > --- a/gdb/arch/amd64.c > +++ b/gdb/arch/amd64.c > @@ -30,14 +30,11 @@ > > #include "../features/i386/x32-core.c" > > -/* Create amd64 target descriptions according to XCR0. If IS_X32 is > - true, create the x32 ones. If IS_LINUX is true, create target > - descriptions for Linux. If SEGMENTS is true, then include > - the "org.gnu.gdb.i386.segments" feature registers. */ > +/* See amd64.h. */ More appropriate to reference arch/amd64.h. > > target_desc * > -amd64_create_target_description (uint64_t xcr0, bool is_x32, bool is_linux, > - bool segments) > +amd64_create_target_description (uint64_t xstate_bv_mask, bool is_x32, > + bool is_linux, bool segments) > { > target_desc_up tdesc = allocate_target_description (); > > @@ -62,13 +59,13 @@ amd64_create_target_description (uint64_t xcr0, bool is_x32, bool is_linux, > if (segments) > regnum = create_feature_i386_64bit_segments (tdesc.get (), regnum); > > - if (xcr0 & X86_XSTATE_AVX) > + if (xstate_bv_mask & X86_XSTATE_AVX) > regnum = create_feature_i386_64bit_avx (tdesc.get (), regnum); > > - if (xcr0 & X86_XSTATE_AVX512) > + if (xstate_bv_mask & X86_XSTATE_AVX512) > regnum = create_feature_i386_64bit_avx512 (tdesc.get (), regnum); > > - if (xcr0 & X86_XSTATE_PKRU) > + if (xstate_bv_mask & X86_XSTATE_PKRU) > regnum = create_feature_i386_pkeys (tdesc.get (), regnum); > > return tdesc.release (); <...> > diff --git a/gdb/arch/i386.c b/gdb/arch/i386.c > index 835df53c75d..84f31439e7a 100644 > --- a/gdb/arch/i386.c > +++ b/gdb/arch/i386.c > @@ -29,10 +29,11 @@ > #include "../features/i386/32bit-segments.c" > #include "../features/i386/pkeys.c" > > -/* Create i386 target descriptions according to XCR0. */ > +/* See i386.h. */ arch/i386.h > > target_desc * > -i386_create_target_description (uint64_t xcr0, bool is_linux, bool segments) > +i386_create_target_description (uint64_t xstate_bv_mask, bool is_linux, > + bool segments) > { > target_desc_up tdesc = allocate_target_description (); > > @@ -44,10 +45,10 @@ i386_create_target_description (uint64_t xcr0, bool is_linux, bool segments) > > long regnum = 0; > > - if (xcr0 & X86_XSTATE_X87) > + if (xstate_bv_mask & X86_XSTATE_X87) > regnum = create_feature_i386_32bit_core (tdesc.get (), regnum); > > - if (xcr0 & X86_XSTATE_SSE) > + if (xstate_bv_mask & X86_XSTATE_SSE) > regnum = create_feature_i386_32bit_sse (tdesc.get (), regnum); > > if (is_linux) > @@ -56,13 +57,13 @@ i386_create_target_description (uint64_t xcr0, bool is_linux, bool segments) > if (segments) > regnum = create_feature_i386_32bit_segments (tdesc.get (), regnum); > > - if (xcr0 & X86_XSTATE_AVX) > + if (xstate_bv_mask & X86_XSTATE_AVX) > regnum = create_feature_i386_32bit_avx (tdesc.get (), regnum); > > - if (xcr0 & X86_XSTATE_AVX512) > + if (xstate_bv_mask & X86_XSTATE_AVX512) > regnum = create_feature_i386_32bit_avx512 (tdesc.get (), regnum); > > - if (xcr0 & X86_XSTATE_PKRU) > + if (xstate_bv_mask & X86_XSTATE_PKRU) > regnum = create_feature_i386_pkeys (tdesc.get (), regnum); > > return tdesc.release (); <...> > diff --git a/gdb/x86-linux-nat.c b/gdb/x86-linux-nat.c > index fc7c5f642ed..a82ad21da27 100644 > --- a/gdb/x86-linux-nat.c > +++ b/gdb/x86-linux-nat.c > @@ -97,15 +97,20 @@ const struct target_desc * > x86_linux_nat_target::read_description () > { > /* The x86_linux_tdesc_for_tid call only reads xcr0 the first time it is > - called, the xcr0 value is stored here and reused on subsequent calls. */ > - static uint64_t xcr0_storage; > + called. The mask is stored in XSTATE_BV_STORAGE and reused on > + subsequent calls. Note that GDB currently supports features for user > + state components only. However, once supervisor state components are > + supported in GDB XSTATE_BV_STORAGE will not be configured based on > + xcr0 only. */ Something about the comment above reads off in the last phrase. Is there a missing connection word? > + static uint64_t xstate_bv_storage; > > if (inferior_ptid == null_ptid) > return this->beneath ()->read_description (); > > int tid = inferior_ptid.pid (); > > - return x86_linux_tdesc_for_tid (tid, &xcr0_storage, &this->m_xsave_layout); > + return x86_linux_tdesc_for_tid (tid, &xstate_bv_storage, > + &this->m_xsave_layout); > } > > Otherwise this looks OK to me. I suppose this was regression tested? I'd be a bit more comfortable if someone more knowledgeable could chime in before this gets approved. But if nobody shows up, we can get it in if others have no concerns. Reviewed-By: Luis Machado