From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id c5+pEhSLFWZEWikAWB0awg (envelope-from ) for ; Tue, 09 Apr 2024 14:38:12 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=freebsd.org header.i=@freebsd.org header.a=rsa-sha256 header.s=dkim header.b=UnVErNji; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3A1191E0C0; Tue, 9 Apr 2024 14:38:12 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B76671E030 for ; Tue, 9 Apr 2024 14:38:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 48CFE3858426 for ; Tue, 9 Apr 2024 18:38:09 +0000 (GMT) Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 25A9B3858D20 for ; Tue, 9 Apr 2024 18:37:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25A9B3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 25A9B3858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=96.47.72.81 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712687870; cv=pass; b=Lus2a3PdVa8gOyFxy14Lgsmd0tXk7x3mzofRds/cbCICmBJmNKckBTXAB0TH0sVwU+HVvxFMmjqx2Q/LEAr3Bk4ubvPiGY44FeIZtPjvgLUT3fJtyif2ssa1B0Si0eLcRAWqjDG/vl1BDWmpA1+MbZpeFxFYGwxBxEfFE6T8n2U= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1712687870; c=relaxed/simple; bh=V82RT5rr0jXUom5bljqmEl9PAMUdEpH4aD4yfZY3avU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=SO9MEzJzvg8zFqDh5x7U4ppTBogqDghlicUn+NOJKPDfp1bkTOm1Cv9ueLgsR9zUN7Jt5u0YjY2gj15RIISIvwA32qqZ0mNWtS1kD5TdiajRHihZJkh7yjccGDqoE+z1xjwBIt3IQ01mnM1/ONggLBhoAkYfsUQMBcgwG6WZcFk= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4VDZT86zbBz4XnY; Tue, 9 Apr 2024 18:37:48 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VDZT85xqbz4prW; Tue, 9 Apr 2024 18:37:48 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712687868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tWFhkSEoaz5wcVqTlhEvoCwJzzcFJWVsMJdo7fqEV6Y=; b=UnVErNjieptnIIia4GlC+h+h6jwcr+6wo3hQ/Mb2DsA4nu6q07ZOJiAMiPczv2FnxBz3Tc +Oe+iCYMtoUfJi54Nbe03n0o6fh2Qjih7GJeMFor4fcWNjMXxyCr6k3M4T2DCcoNnXiQA9 3r+//BF2hgY9y2e33TS5NG2Vy1G3Weshsa+DQ+oyFsuxUcjgexo+8CklhkMsgtz/34U885 L6C2SD9H4yVTdtVLEG1DLy1JrNw6WGRm96eabopU6ogzo7kCkhTMTtymoYStOqHwpWLowt y1fuV7ocEM0cQfnGsMPOovVTD53zTPE0/lNM6r1sqDsoxOwsUZVS7lW13sgmLA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1712687868; a=rsa-sha256; cv=none; b=eAxwE8NA7ehoqYDy35rcSujSYouWm2gzjlIGiLHlhrTNyDFBTJLwS+3Tk0MNu57uRtEPfG FN2olZ+ZHBANaXFgFFjSXkEnCkqEdaZ5KkTdjTmoZivNeVVAhR+FeKRH9OyPLu9MJEBL5V BarvgLgXaE0DPdinfhPEfieX6OR36IVqj7PXFfxi7LWyF7kO5HnywDSkU915eiqu8WCTaP zXXRKjLDVRixy8oOkvyv44tDfzc5QFQ/VJFFfl8cC2cvgNgyESSOL5xUJu0gbkxDKJPQjj uPd10yQUr2oGDNx+OhPlWQqvze9ZfMnmnCr43MMj8IkunCOQAPryLuq6ihQUHw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712687868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tWFhkSEoaz5wcVqTlhEvoCwJzzcFJWVsMJdo7fqEV6Y=; b=wFtDsgb3GlLvoh8atx9Qx40vBXY4+q7Keg1ijo5+pDGaV/F5Ojg3tN2+eqDz3CcoO0fvCn 5IS5omV39RMjiyqzEv3MNmmyC9W52U3cBhEV5kfzl5k17/qLK44lc16kWcsT1RGCYp6oTu miI26m5T8DacuWc39FnTaYrw/Ec2HmD9oXIZC48wCz0zZmFKwTN55Lk9R7t5DZj+KDHkNS y1IxsynXk25S4R/4DZr+Kp9/NhxCgL46Vc5sLiBXNbAquT1eCn8cqWSO+O5IY3B/6RTG+Y OhG1+XzTd2RVxzHVOpGxPfzbt9DvxUqiDQKQC+HXCfXVL+kudeh0KfMoLS/BLQ== Received: from [IPV6:2601:644:937f:4c50:7d01:266e:5339:1e93] (unknown [IPv6:2601:644:937f:4c50:7d01:266e:5339:1e93]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VDZT83jWtz1Ffc; Tue, 9 Apr 2024 18:37:48 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 9 Apr 2024 11:37:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv4 00/10] x86/Linux Target Description Changes Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 4/5/24 8:33 AM, Andrew Burgess wrote: > In v4: > > - I tried merging V3, but it turned out I broke pretty much > everything that wasn't x86 based when configured with > --enable-targets=all, > > - The problem was a failure to correctly split the shared code > between the gdb/arch/ and gdb/nat/ directories, as a consequence, > code which is needed on a non x86 based host to support x86 based > targets wasn't available to the compilation, and the build failed, > > - In V4 I've gone through every patch and resplit the code in a way > which I now believe is correct, I've done the following tests: > > + On a non x86 host I've built GDB to support only the current > host as a target, to support all targets, and to support x86-64 > and i386 linux targets, > > + On an i386 virtual machine I built GDB only for the host as a > target, and for all targets. I regression tested the all targets > build for unix, native-gdbserver, and native-extended-gdbserver, > > + On an x86-64 machine I've built GDB for only the current host as > a target, and for all targets. I regression tested the all targets > build for unix, native-gdbserver, and native-extended-gdbserver. > > - Only patches 6, 8, and 10 require significant review. All of the > other patches are pretty trivial (though reviews always welcome). > > - I think there's more improvements that can be made to the x86 > target description creation/lookup/caching. This series only > changes the Linux lookup, and we still cache i386/amd64/x32 > separately. > > In the future I think we can merge all x86 target description > caching into a single data structure, this would be for all OS > variants and all ABI variants. > > Though making that "grand unification" will certainly require some > of the code in this series to change, I think the bulk of it will > remain, and trying to do everything in one series is just going to > result in an even larger series. I'd prefer to get these first > patches merged, then come back to build on this work once this is > merged and we know there's no problems with it. > > In v3: > > - Rebased. Nasty merge conflict with 4bb20a6244b7091 which I think > I've resolved, but am unable to test. Reposting so the author of > that other commit can validate. > > - Initial testing looks good. Full tests are still running. > > In v2: > > - Rebase to current upstream/master, no merge conflicts, > > - Retested. I re-read this series and it does look ok to me still, but I thought V3 was ok as well. :-P Your testing matrix described above for V4 seems reasonable for catching what you ran into with V3. Approved-By: John Baldwin -- John Baldwin