From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /sDgDaIsumqWBBEAWB0awg (envelope-from ) for ; Mon, 28 Sep 2026 05:00:18 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=CW/gntdj; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sSaMRMFB; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ApIumvBn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7xkoe6fB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2371A1E033; Mon, 28 Sep 2026 05:00:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D900F1E033 for ; Mon, 28 Sep 2026 05:00:16 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0DAF94BA9038 for ; Mon, 28 Sep 2026 09:00:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0DAF94BA9038 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=CW/gntdj; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sSaMRMFB; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ApIumvBn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7xkoe6fB Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id C83434BA23F8 for ; Mon, 28 Sep 2026 08:59:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C83434BA23F8 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C83434BA23F8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790585991; cv=none; b=u2IO4KW1WH9hCx2KTbdK9Btx2qrAPgMy7JFvtRB9IFxaQyuS39PmuS4f/lGfbPTHJZLEDzql4UXCfRoWBTCptzanfsD/kx/tbG0Yl6BrgUh0xyag27wpQaRM+NZz8n/emNszNrruFRdc8H262+GQ6RBDcW0gZ6MsaHQibaVkboM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790585991; c=relaxed/simple; bh=o7UsJZcnmROkJB9mkh39B6qSH+NFvjMD23TbRL3Xw1Y=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=Izg8d1k9gcQ4RoAF8bczBY3K7qQTxyCc5Sj6e575MvxtwFFtyuZrWT/8kinPjZpYdkykCEdb+spYDqsURlrFHdDe4ZSxAJO0gMpoiyCK0lROZJMOCyYrw3SFoDARgeKnTAE/lyCDD/BClZAEmmZMaod3TxreJmASQ+ucEuNleuI= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=CW/gntdj; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=sSaMRMFB; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ApIumvBn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=7xkoe6fB DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C83434BA23F8 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 895011FF3D; Mon, 28 Sep 2026 08:59:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790585986; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5fv09W68gr2DowzShh/E9Tjq9+C6mnkvZfdcRCwpv+U=; b=CW/gntdjhtXxu//Q2CquVnoJDwnM5iEOFRDGzuBhFOXCUlwzENBUP9G+k0p2aVXSlA1dOD ANH0GjuXleBKBMAcRWyCviEi4UzvYxfkRfUCilEYdVtBDKmFmTeqqDCn766zvFFRFp31RQ J5V8M7vSnlgUoeInb5DlCvSXN3OY3W0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790585986; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5fv09W68gr2DowzShh/E9Tjq9+C6mnkvZfdcRCwpv+U=; b=sSaMRMFBdpHT/a4YiPKoiH1o4Ng37ccFEzA0E8uNudqNA5M2HXzWvVmfGMwayUdIGilzzz BU3yMPS7cm/V61Cg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ApIumvBn; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=7xkoe6fB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790585982; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5fv09W68gr2DowzShh/E9Tjq9+C6mnkvZfdcRCwpv+U=; b=ApIumvBnb5ewfbi76suL/Sv5u6b4mok7tWwel2Pj/U2lfbKB4F2QJwkBg0nkcE7Af2no8q qO4BnZhiUMa43nxxn3YKTfH+PVtNkQbSzKq1TmqXfqBxGzHTRQ5EpXs1pKGP9s2m54I9m9 V+rYOl30PTwPGy13NjeZDeWc+Re2W9M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790585982; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5fv09W68gr2DowzShh/E9Tjq9+C6mnkvZfdcRCwpv+U=; b=7xkoe6fB6UP+yxlWRjDOEZEEF8wdC2EHnU4Lp6EiN8szsGTodrnzS9h8JKromid7IBToIU pJeKpJNGTnWZhIDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 51BE4133F3; Mon, 28 Sep 2026 08:59:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aGmoCH4sumqUIQAAD6G6ig (envelope-from ); Mon, 28 Sep 2026 08:59:42 +0000 Message-ID: Date: Mon, 28 Sep 2026 10:59:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] [gdb/testsuite] Use gdb_exit_cleanup a bit more To: Andrew Burgess , gdb-patches@sourceware.org References: <20260919084237.1045724-1-tdevries@suse.de> <20260919084237.1045724-3-tdevries@suse.de> <87pkxz13gf.fsf@redhat.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87pkxz13gf.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 895011FF3D X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:email,suse.de:mid]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/27/26 10:52 AM, Andrew Burgess wrote: > Tom de Vries writes: > >> I ran into trouble running test-case gdb.base/quit-live.exp using a remote >> host configuration: >> - host board local-remote-host >> - target board remote-gdbserver-on-localhost. >> >> The problem is that the test-case makes gdb quit without updating >> gdb_spawn_id. Consequently, default_gdb_exit tries to exit gdb. >> It does so by sending quit to gdb and waiting for it to exit, which get us: >> ... >> ERROR: : spawn id exp9 not open >> ... >> >> Fix this using gdb_exit_cleanup. Likewise in gdb.threads/killed.exp. >> --- >> gdb/testsuite/gdb.base/quit-live.exp | 1 + >> gdb/testsuite/gdb.threads/killed.exp | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/gdb/testsuite/gdb.base/quit-live.exp b/gdb/testsuite/gdb.base/quit-live.exp >> index 14f87f9b7f8..8dae4fe2aca 100644 >> --- a/gdb/testsuite/gdb.base/quit-live.exp >> +++ b/gdb/testsuite/gdb.base/quit-live.exp >> @@ -152,6 +152,7 @@ proc quit_with_live_inferior {appear_how extra_inferior quit_how} { >> gdb_test_multiple "" $test { >> eof { >> pass $test >> + gdb_exit_cleanup > > There's another place in this test script which detects eof from GDB, > but you've not added the gdb_exit_cleanup call there. > > Should we also be patching that location? If not why not? And if the > answer is there's a good reason why not, then I think it is worth > mentioning in the commit message, and as a comment at that location in > the code. > Hi Andrew, thanks for the review(s). The focus of this commit is to address a specific error, and the addition in quit_with_live_inferior fixes it. I did not encounter the same error in test_quit_with_sig, but it's probably a good idea to apply the same pattern. [ It might even be necessary on msys2, but AFAIR currently the test-case fails in such a way that the eof is not reached. I briefly tried making the testcase work using some kill equivalent, but that didn't work out. ] Anyway, I've added the gdb_exit_cleanup in test_quit_with_sig, and I've updated the commit message to: ... Fix this in quit_with_live_inferior using gdb_exit_cleanup. Likewise in gdb.threads/killed.exp. While we're at it, also add default_gdb_exit for another eof clause in gdb.base/quit-live.exp, in proc test_quit_with_sig. ... and pushed. Thanks, - Tom > Thanks, > Andrew >