From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43664 invoked by alias); 9 Apr 2018 19:55:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43647 invoked by uid 89); 9 Apr 2018 19:55:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=yours X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Apr 2018 19:55:19 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w39JtCPJ023632 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 9 Apr 2018 15:55:17 -0400 Received: by simark.ca (Postfix, from userid 112) id 752541EF60; Mon, 9 Apr 2018 15:55:12 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id B566E1E17E; Mon, 9 Apr 2018 15:55:11 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 09 Apr 2018 19:55:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Add selftests for range_contains and insert_into_bit_range_vector In-Reply-To: References: <20180407143801.19596-1-simon.marchi@polymtl.ca> <09d2a032-8726-6351-ab9a-63574734a3e5@ericsson.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 9 Apr 2018 19:55:12 +0000 X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00168.txt.bz2 On 2018-04-09 15:35, Pedro Alves wrote: > On 04/09/2018 08:01 PM, Simon Marchi wrote: >> On 2018-04-07 02:33 PM, Pedro Alves wrote: >>> See patch below on top of yours implementing most of the suggestions >>> above, except the missing comments. >>> >>> WDYT? >> >> I agree with all your suggested changes. Here is the merged patch I >> would push. >> I also changed "test_range_contains" to "test_ranges_contain" to match >> the name >> of the function. > > Thanks, please push. > > Pedro Alves Done, thanks. Simon