From: Pedro Alves <palves@redhat.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, Simon Marchi <simark@simark.ca>
Subject: Re: [PATCHv2 2/3] gdb/regcache: When saving, ignore registers that can't be read
Date: Tue, 27 Nov 2018 16:57:00 -0000 [thread overview]
Message-ID: <b5bba8b4-ed95-d50d-df0f-040d83d4fbf8@redhat.com> (raw)
In-Reply-To: <20181127153008.GG2834@embecosm.com>
On 11/27/2018 03:30 PM, Andrew Burgess wrote:
> Thanks for taking the time to review this patch.
>
> Just wanted to confirm that (subject to review) the above feedback
> doesn't prevent patch #1 or #3 being merged, correct?
Correct.
> Patch #1 specifically makes the inferior call error rather than
> assert, which feels like it doesn't raise the same concerns you
> discuss above.
Absolutely.
Thanks,
Pedro Alves
prev parent reply other threads:[~2018-11-27 16:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 18:17 [PATCH] " Andrew Burgess
2018-11-26 2:48 ` Simon Marchi
2018-11-27 11:13 ` [PATCHv2 1/3] gdb/infcall: Make infcall_suspend_state more class like Andrew Burgess
2018-11-27 11:13 ` [PATCHv2 0/3] Handle Errors While Preparing For Inferior Call Andrew Burgess
2018-12-12 15:16 ` [PATCHv3 2/2] gdb: Update test pattern to deal with native-extended-gdbserver Andrew Burgess
2018-12-12 16:13 ` Pedro Alves
2018-12-12 15:16 ` [PATCHv3 1/2] gdb/infcall: Make infcall_suspend_state more class like Andrew Burgess
2018-12-12 16:13 ` Pedro Alves
2018-12-12 15:16 ` [PATCHv3 0/2] Handle Errors While Preparing For Inferior Call Andrew Burgess
2018-12-12 16:14 ` Pedro Alves
2018-12-12 17:40 ` Andrew Burgess
2018-11-27 11:13 ` [PATCHv2 3/3] gdb: Update test pattern to deal with native-extended-gdbserver Andrew Burgess
2018-11-27 11:13 ` [PATCHv2 2/3] gdb/regcache: When saving, ignore registers that can't be read Andrew Burgess
2018-11-27 12:41 ` Pedro Alves
2018-11-27 15:30 ` Andrew Burgess
2018-11-27 16:57 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5bba8b4-ed95-d50d-df0f-040d83d4fbf8@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox