From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125213 invoked by alias); 27 May 2016 12:00:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125197 invoked by uid 89); 27 May 2016 12:00:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=collected, Antoine, antoine X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 27 May 2016 12:00:57 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 557E3C04B327; Fri, 27 May 2016 12:00:56 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4RC0rrP018294; Fri, 27 May 2016 08:00:54 -0400 Subject: Re: [PATCH 1/4] Move trace conditions tests from ftrace.exp to trace-condition.exp To: Antoine Tremblay , gdb-patches@sourceware.org References: <1463504594-4419-1-git-send-email-antoine.tremblay@ericsson.com> From: Pedro Alves Message-ID: Date: Fri, 27 May 2016 12:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1463504594-4419-1-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00486.txt.bz2 On 05/17/2016 06:03 PM, Antoine Tremblay wrote: > This patch moves conditional tests that were done in ftrace.exp to > trace-conditon.exp. Typo conditon.exp. > > Note that emit_ref is now tested by the anarg local variable there is no > need to test the register directly. > > The test coverage remains the same. How did you determine it that it's the same? E.g., seems like the <, >, etc., conditions in ftrace.exp use a global variable, while the trace-condition.exp ones use constants. I also notice that all tests in trace-condition.exp expect 10 frames to be collected. If a condition's handling is broken and the tracepoints ends up unconditional, will we ever notice? Seems like we have counter-cases using the same operators but that eval false, like (relative to your patch): test_tracepoints $trace_command "21 == 21" 10 + test_tracepoints $trace_command "21 == 22" 0 test_tracepoints $trace_command "21 != 42" 10 + test_tracepoints $trace_command "21 != 21" 0 Thanks, Pedro Alves