Re: [PATCH V5] CTF: multi-CU and archive support

Tom Tromey
2021-06-11T18:19:20Z

>>>>> "Lancelot" == Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org> writes:

Lancelot> Should be

Lancelot> if (sym != nullptr)

Agreed.

>> pst = new ctf_psymtab (name, partial_symtabs, objfile->per_bfd, 0);

Lancelot> I am a bit confused by this one. As far as I can see, there is no way
Lancelot> it can ever be deleted. Again, I am not so familiar with the code yet
Lancelot> so I might have missed something, but hopefully not.

psymtabs register themselves with a storage object.
This is unfortunate but it is how it has been done for a long time, and
nobody has bothered to clean it up.

Tom