From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124622 invoked by alias); 31 May 2018 14:57:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124589 invoked by uid 89); 31 May 2018 14:57:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 May 2018 14:57:23 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4803776F91; Thu, 31 May 2018 14:57:22 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id A4ED363529; Thu, 31 May 2018 14:57:21 +0000 (UTC) Subject: Re: [PATCH 4/8] Enable SVE for GDB To: Alan Hayward , gdb-patches@sourceware.org References: <20180511105256.27388-1-alan.hayward@arm.com> <20180511105256.27388-5-alan.hayward@arm.com> Cc: nd@arm.com From: Pedro Alves Message-ID: Date: Thu, 31 May 2018 14:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180511105256.27388-5-alan.hayward@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00856.txt.bz2 On 05/11/2018 11:52 AM, Alan Hayward wrote: > + if (feature_sve != NULL) > + { > + gdb_assert (feature_fpu == NULL); > + > + /* Validate the descriptor provides the mandatory sve registers "description". Please "grep -i" your patches for "descriptor", since this appears in other spots. Uppercase "SVE", I'd assume. I noticed that at least patch #8 uses lowercase "sve" in an error message, which should probably be fixed. Suggest grepping the patches for that too. > + and allocate their numbers. */ > + for (i = 0; i < ARRAY_SIZE (aarch64_sve_register_names); i++) > + valid_p &= tdesc_numbered_register (feature_sve, tdesc_data, Thanks, Pedro Alves