From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58956 invoked by alias); 8 Sep 2018 22:31:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54435 invoked by uid 89); 8 Sep 2018 22:30:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=subcommands X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 08 Sep 2018 22:30:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1536445851; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hQH5y/twixae0wZPOgAfpj+r/D/MEHRSpFkx0gbOKQE=; b=Rwt2VnrsHGxSYbj0BU9VbqybV36W1JXCl41EeB//+WLLOB07+rMCncJmxzndBuhO QWrai+jU6MOcNfW/X8AlookvHhLYHDSmptC7wruH4/B/xkkwvdXz8WWbJz4VIm6U sM5icYCfuKyq6ZOO+eeGMhYe5vkcfeUJ6cqnX3Qu5bM=; Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id FB.FA.31332.B9D449B5; Sun, 9 Sep 2018 00:30:51 +0200 (CEST) Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Sun, 9 Sep 2018 00:30:50 +0200 Received: from NAM01-SN1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Sun, 9 Sep 2018 00:30:50 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+ni7bBYtFBFwUwtQsLRuEALYK62yJqz1D7eg27SgeD0=; b=Pgdf2KtXXm3nIWI+O1TPDssJ1ZWneqr0b5HU5aT6NNCAAzNsPvFpf5smwbXYLunsvGP24bHFED2dbIN+0gs1BDKqjFqBw2Q5v+txE5bP8WnZaebHL9/lBepprudtn+P2F+GIkVv4U5ld+/+jM3J6KYtLfUbAjWrmedz/QTifMMw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [100.94.32.129] (192.176.1.81) by BN7PR15MB2386.namprd15.prod.outlook.com (2603:10b6:406:8c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1122.17; Sat, 8 Sep 2018 22:30:46 +0000 Subject: Re: [PATCH 2/5] Add a new 'info proc files' subcommand of 'info proc'. To: Eli Zaretskii , John Baldwin CC: References: <20180908003659.37482-1-jhb@FreeBSD.org> <20180908003659.37482-3-jhb@FreeBSD.org> <83bm98trel.fsf@gnu.org> From: Simon Marchi Message-ID: Date: Sat, 08 Sep 2018 22:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <83bm98trel.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00210.txt.bz2 On 2018-09-08 07:49 AM, Eli Zaretskii wrote: >> From: John Baldwin >> Date: Fri, 7 Sep 2018 17:36:56 -0700 >> >> This command displays a list of open file descriptors. > > Thanks. > >> + add_cmd ("files", class_info, info_proc_cmd_files, _("\ >> +List of open files."), > > IMO, this doc strings is too terse. I suggest to expand it telling > that the command shows the files open by the process being debugged. The info proc commands accept a pid, which allows you to refer to any process, not only those debugged by GDB. Other info proc commands use use the generic form "of the process" info proc cmdline -- List command line arguments of the process I think that's sufficient, especially that users are likely to see it in the context of "help info proc", which describes what argument you can pass: (gdb) help info proc Show /proc process information about any running process. Specify any process id, or use the program being debugged by default. List of info proc subcommands: info proc all -- List all available /proc info info proc cmdline -- List command line arguments of the process info proc cwd -- List current working directory of the process info proc exe -- List absolute filename for executable of the process info proc mappings -- List of mapped memory regions info proc stat -- List process info from /proc/PID/stat info proc status -- List process info from /proc/PID/status Simon