From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78388 invoked by alias); 12 Feb 2020 00:53:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77934 invoked by uid 89); 12 Feb 2020 00:53:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:561 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 00:53:24 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 217451ED42; Tue, 11 Feb 2020 19:53:23 -0500 (EST) Subject: Re: [PATCH 2/8] Dont' allow copying of auto_obstack To: Tom Tromey , Christian Biesinger Cc: gdb-patches References: <20200208152758.29385-1-tom@tromey.com> <20200208152758.29385-3-tom@tromey.com> <87blq4d5hw.fsf@tromey.com> From: Simon Marchi Message-ID: Date: Wed, 12 Feb 2020 00:53:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <87blq4d5hw.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00424.txt.bz2 On 2020-02-11 7:16 p.m., Tom Tromey wrote: >>>>>> "Christian" == Christian Biesinger writes: > >> On Sat, Feb 8, 2020, 10:28 Tom Tromey wrote: >> Add DISABLE_COPY_AND_ASSIGN to struct auto_obstack, to prevent copying >> it. Copying an auto_obstack would be a bug. > > Christian> Typo in the subject/first line (Dont' -> Don't) > > Thanks, I fixed this. > > Tom > That makes sense, I think you should push this one right away, independently from this series. Simon