Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Luis Machado <lgustavo@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Restrict gdb.base/gcore-relro-pie.exp to native/linux targets
Date: Thu, 23 Feb 2017 14:54:00 -0000	[thread overview]
Message-ID: <b4624f3a-ede3-6618-b118-91b1cb7dd4a5@redhat.com> (raw)
In-Reply-To: <6e1f21a5-3283-b30e-d7fa-e2c1453af882@codesourcery.com>

On 02/23/2017 02:47 PM, Luis Machado wrote:

> I still think it doesn't make much sense to run these tests if we're not
> sure gcore will support them. 

I don't understand what you're saying.  We can't be sure up
front.  The "gcore" that is run is GDB's "gcore" command.  If that 
doesn't work, gdb_gcore_cmd calls unsupported, and the rest of the 
testcase is skipped.

> They may run a few early tests/setup
> tests, but that won't translate into meaningful PASSes. But i'm ok
> keeping it as-is if others think the early test PASSes are useful.

Looks like it's been useful to catch a startup code problem.  ;-)

Thanks,
Pedro Alves


  reply	other threads:[~2017-02-23 14:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23 14:13 Luis Machado
2017-02-23 14:25 ` Pedro Alves
2017-02-23 14:47   ` Luis Machado
2017-02-23 14:54     ` Pedro Alves [this message]
2017-02-23 15:10       ` Luis Machado
2017-02-23 15:43         ` Pedro Alves
2017-02-23 16:16           ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4624f3a-ede3-6618-b118-91b1cb7dd4a5@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox