From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>, Tom Tromey <tom@tromey.com>
Cc: Andreas Schwab <schwab@suse.de>, gdb-patches@sourceware.org
Subject: Re: [RFA] Use watchpoint's language when re-parsing expression
Date: Fri, 19 May 2017 14:32:00 -0000 [thread overview]
Message-ID: <b42c3596-7133-a2f7-7077-801e7c2dac18@redhat.com> (raw)
In-Reply-To: <20170519135113.agxaih5pcdeew3co@adacore.com>
On 05/19/2017 02:51 PM, Joel Brobecker wrote:
>> Andreas> The docs say that gdb is supposed to support C style casts in every
>> Andreas> language. Also, there is the {type} operator that is also supported in
>> Andreas> every language.
> [...]
>> Finally, I'm not at all certain that C-style casts or the {type}
>> operator can be added to the Rust expression parser without breaking
>> something else. And, that seems like a complex request just to unbreak
>> what amount to an implementation detail.
>
> FWIW, I also never noticed this, and I share the concerns about
> making this a requirement for all languages. It really depends
> on the language itself whether it's easy to implement such feature,
> and I would hate for language parsers to be harder to maintain
> just so we can provide a bit of a C-centric view to every language
> we support.
>
> I vote for downgrading the requirement and amending the documentation
> instead.
>
I agree. The patch LGTM.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-05-19 14:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 2:39 Tom Tromey
2017-05-18 7:37 ` Andreas Schwab
2017-05-18 21:42 ` Tom Tromey
2017-05-19 13:51 ` Joel Brobecker
2017-05-19 14:32 ` Pedro Alves [this message]
2017-05-20 4:07 ` Tom Tromey
2017-05-20 8:24 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b42c3596-7133-a2f7-7077-801e7c2dac18@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=schwab@suse.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox