From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iRMiJF/t4mnEvSIAWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 22:33:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776479583; bh=TOnPKt4UhAOrUSF3xTR78V+Oisjs0iFBgkcHOFup8Rk=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=d4+Xd8Bpd8A4dHETv9twi7mZWAuZNCof4zxxzhzyDirqDbywIYEtsXw24sWVM8VGp c/h1yzqrPCo0WRmJ3Q6TvaX4NZV0C8t4ecrzRysyqaftZA4JzR3JI1u5UYoWJxAvML NNiMGRyOft8A6C/CFuTc8TfeiC7HfvzaXg4um+xw= Received: by simark.ca (Postfix, from userid 112) id 8B2E81E0B1; Fri, 17 Apr 2026 22:33:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=OTU3XuHY; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A38841E04F for ; Fri, 17 Apr 2026 22:33:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 75B384D108DE for ; Sat, 18 Apr 2026 02:33:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 75B384D108DE Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=OTU3XuHY Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 548624BA2E32 for ; Sat, 18 Apr 2026 02:32:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 548624BA2E32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 548624BA2E32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776479558; cv=none; b=TYbBrGPgk79/CLIvlHkpiKAL02R/M4+634kgC9LnFgWhgbjLx5X4A9lpj4l/LM2o/PoGUVTAp9SqqCATE+djvmqEKNGSRSUKcmmgqE3CiAQHgTpTnrWzn6p+A1PJSG32Hldvmpx/NkvReLRnE7PxzrMmi+zHa70XDpdfDXtZ3yQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776479558; c=relaxed/simple; bh=TOnPKt4UhAOrUSF3xTR78V+Oisjs0iFBgkcHOFup8Rk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=QyKy7zox0HIKHtyuvTAB7OH5Mi8q7gctjc5GgsVcrIi22QgmgTiEgrqiO1gfpzjmEYzP9eDB/YiRwMYP/VfopllA8G3aUCI3yA7XMUcFm6GyqAuKwIKxnMHpdjg76BMx3f1kd5WLfe3KHCt1yNB7Y0XKeFmGyoAaZbdasL6KslY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 548624BA2E32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1776479557; bh=TOnPKt4UhAOrUSF3xTR78V+Oisjs0iFBgkcHOFup8Rk=; h=Date:Subject:To:References:From:In-Reply-To:From; b=OTU3XuHY48v81cNvuKY28iH7N0acJchUq5do8CPg8NdYZm91QNOKSNzbx99ITbHsW 6Sq0uQ2jRCheogzeAsI/x1lKXs+HhJO5xWG9riJy3Kcwb9WAC6o0zEw0+OGpQlxSxo XB9ETAwoTckIp8c4V0mHcI6ugmKJ6vPttAAHzMSY= Received: by simark.ca (Postfix) id EAF321E04F; Fri, 17 Apr 2026 22:32:36 -0400 (EDT) Message-ID: Date: Fri, 17 Apr 2026 22:32:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Remove "prefix" argument from cp_type_print_method_args To: Tom Tromey , gdb-patches@sourceware.org References: <20260418021030.2629194-1-tom@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20260418021030.2629194-1-tom@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-04-17 22:10, Tom Tromey wrote: > The "prefix" argument to cp_type_print_method_args is only ever the > empty string, so it can be removed. > --- > gdb/c-typeprint.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/gdb/c-typeprint.c b/gdb/c-typeprint.c > index 821b78becf4..e418aca56a4 100644 > --- a/gdb/c-typeprint.c > +++ b/gdb/c-typeprint.c > @@ -244,7 +244,7 @@ cp_type_print_derivation_info (struct ui_file *stream, > /* Print the C++ method arguments ARGS to the file STREAM. */ > > static void > -cp_type_print_method_args (struct type *mtype, const char *prefix, > +cp_type_print_method_args (struct type *mtype, > const char *varstring, int staticp, > struct ui_file *stream, > enum language language, > @@ -255,8 +255,6 @@ cp_type_print_method_args (struct type *mtype, const char *prefix, > int varargs = mtype->has_varargs (); > int i; > > - fprintf_symbol (stream, prefix, > - language_cplus, DMGL_ANSI); > fprintf_symbol (stream, varstring, > language_cplus, DMGL_ANSI); > gdb_puts ("(", stream); > @@ -1164,7 +1162,6 @@ c_type_print_base_struct_union (struct type *type, struct ui_file *stream, > struct type *mtype = TYPE_FN_FIELD_TYPE (f, j); > > cp_type_print_method_args (mtype, > - "", > method_name, > staticp, > stream, language, Seems obvious. Approved-By: Simon Marchi Simon