From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from re-prd-fep-045.btinternet.com (mailomta4-re.btinternet.com [213.120.69.97]) by sourceware.org (Postfix) with ESMTPS id E5730385B835 for ; Thu, 9 Apr 2020 14:57:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E5730385B835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dronecode.org.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=jon.turney@dronecode.org.uk Received: from re-prd-rgout-004.btmx-prd.synchronoss.net ([10.2.54.7]) by re-prd-fep-045.btinternet.com with ESMTP id <20200409145731.NLMI3906.re-prd-fep-045.btinternet.com@re-prd-rgout-004.btmx-prd.synchronoss.net> for ; Thu, 9 Apr 2020 15:57:31 +0100 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com X-Originating-IP: [31.51.205.58] X-OWM-Source-IP: 31.51.205.58 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeduhedrudelgdejiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhnucfvuhhrnhgvhicuoehjohhnrdhtuhhrnhgvhiesughrohhnvggtohguvgdrohhrghdruhhkqeenucfkphepfedurdehuddrvddthedrheeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurdduudejngdpihhnvghtpeefuddrhedurddvtdehrdehkedpmhgrihhlfhhrohhmpeeojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhequceuqfffjgepkeeukffvoffkoffgpdhrtghpthhtohepoehguggsqdhprghttghhvghssehsohhurhgtvgifrghrvgdrohhrgheq X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.117] (31.51.205.58) by re-prd-rgout-004.btmx-prd.synchronoss.net (5.8.340) (authenticated as jonturney@btinternet.com) id 5E3A181A0A2F1184 for gdb-patches@sourceware.org; Thu, 9 Apr 2020 15:57:31 +0100 Subject: Re: [PATCH v3 00/29] Windows code sharing + bug fix To: gdb-patches@sourceware.org References: <20200313190855.28662-1-tromey@adacore.com> <87pnchogza.fsf@tromey.com> <352012716.4805895.1586384237188@mail.yahoo.com> <87r1wxmkzf.fsf@tromey.com> From: Jon Turney Message-ID: Date: Thu, 9 Apr 2020 15:57:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <87r1wxmkzf.fsf@tromey.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, FORGED_SPF_HELO, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Apr 2020 14:57:34 -0000 On 09/04/2020 03:49, Tom Tromey wrote: >>>>>> "Hannes" == Hannes Domani via Gdb-patches writes: > > Hannes> I seems I kinda missed to actually use Wow64SuspendThread when I implemented > Hannes> the WOW64 stuff. > > Could you double-check to make sure I didn't mess it up when rebasing > this series over your patches? > > Hannes> Maybe I should just try to implement the WOW64 stuff for gdbserver as well, and > Hannes> then try to move more shared stuff into nat/windows-nat.c? > > It would be nice to try to keep the code more in sync. > They still aren't identical but they do share quite a bit more now. > So, unless it's unusually hard, I would say yes. I wonder if SuspendThread() is actually needed at all, since it doesn't make a huge amount of sense for the debugee to still be running when WaitForDebugEvent() returns.