Re: [PATCH 06/40] Expression completer should not match explicit location options

Pedro Alves
2017-06-29T11:08:44Z

On 06/29/2017 11:56 AM, Pedro Alves wrote:

> The patch fixes this by having the expression_completer function
> bypass the function that completes explicit locations:
>
> /* Not ideal but it is what we used to do before... */
> - return location_completer (ignore, p, word);
> + return linespec_location_completer (ignore, text, word);
>

Hmm, reading this back made my realize that I'm dropping "p"
here, which is computed just above. That doesn't make a difference
to the test added by 37cd5d19fecc (2008), which was the commit
that added that code. Hmm, looks like that's a bit of dead code
we can remove.

Thanks,
Pedro Alves