Re: [PATCH 09/40] Rename make_symbol_completion_list_fn -> symbol_completer

Yao Qi
2017-06-28T21:40:13Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 775 bytes --]

On 17-06-02 13:22:07, Pedro Alves wrote:
> "make_symbol_completion_list_fn" is odly named when you look at a list
> of "standard" completers, like the Python/Guild completer lists
> adjusted by this patch. Rename / move it to completers.h/c, for
> consistency.
>
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * completer.c (symbol_completer): New function, based on
> make_symbol_completion_list_fn.
> * completer.h (symbol_completer): New declaration.
> * guile/scm-cmd.c (cmdscm_completers): Adjust.
> * python/py-cmd.c (completers): Adjust.
> * symtab.c (make_symbol_completion_list_fn): Delete.
> * symtab.h (make_symbol_completion_list_fn): Delete.
> * cli/cli-decode.c (add_cmd): Adjust.

Patch is good to me.

--
Yao (é½å°§)