Re: [PATCH 22/40] get_int_var_value

Pedro Alves
2017-07-20T17:15:42Z

On 07/17/2017 11:11 PM, Keith Seitz wrote:
> On 06/02/2017 05:22 AM, Pedro Alves wrote:
>> I noticed that get_int_var_value's parameters could use some
>> constification. And then realized that client code would become
>> simpler by changing the interface to return the success/failure
>> indication as actual return value, as allows getting rid of the the
>> local "boolean" variable.
>
> It is certainly more appropriate for Joel to comment, but I did look through the patch, and it is a pretty straightforward change. I didn't notice any issues.

Thanks! I want ahead and push it in to get it out of
the way of the following, more interesting patches. I'll of
course gladly address any concern that Joel may have.

Thanks,
Pedro Alves