Re: [PATCH 17/40] Linespec lexing and C++ operators

Pedro Alves
2017-07-17T19:34:02Z

On 07/14/2017 10:45 PM, Keith Seitz wrote:
> On 06/02/2017 05:22 AM, Pedro Alves wrote:

>>
>> (gdb) b -function operator<(int, int) -labe[TAB] # nothing happens
>>
>> gdb incorrectly thinks "-labe" is part of the "unclosed" template
>> parameter list started with "<".
>
> Ouch. The best laid plans...

:-)

>> + p--;
>> + if (p - start >= CP_OPERATOR_LEN)
>> + {
>> + p-= CP_OPERATOR_LEN;
>
> This is a cut-n-paste-o (that's a typo propagated via cut-n-paste). Missing a space before the operator.

Whoops.

>> + LS_TOKEN_STOKEN (token).ptr = start;
>> + LS_TOKEN_STOKEN (token).length = PARSER_STREAM (parser) - start;
>
> Line length > 80?

Indeed.

Pushed with the obvious fixes.

Thanks,
Pedro Alves