Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: [PATCH 7/6] More gdb.threads/attach-into-signal.exp stale stopped bits (Re: [PATCH 6/6] Drop /proc/PID/status polling from gdb.threads/attach-into-signal.exp)
Date: Tue, 24 Oct 2017 10:09:00 -0000	[thread overview]
Message-ID: <b3c61796-3066-7753-f024-937ea2b2234a@redhat.com> (raw)
In-Reply-To: <86fua957l7.fsf@gmail.com>

On 10/24/2017 08:27 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
> 
>> gdb/testsuite/ChangeLog:
>> yyyy-mm-dd  Pedro Alves  <palves@redhat.com>
>>
>> 	* gdb.threads/attach-into-signal.exp: Remove whole "stoppedtry"
>> 	loop.
> 
> Patch is good to me.
> 

Hmmm, noticed a related stale bit further below.  Here's a patch
that removes it.

From 8a645cfef64d4251f34f644792a756959ea440d4 Mon Sep 17 00:00:00 2001
From: Pedro Alves <palves@redhat.com>
Date: Mon, 23 Oct 2017 17:46:07 +0100
Subject: [PATCH] More gdb.threads/attach-into-signal.exp stale stopped bits

This looks as stale as the other bit that was removed in a previous
commit.  The test isn't attaching to a stopped process.  (And if this
were generaly necessary, then it'd be better done from within
kill_wait_spawned_process.)

gdb/testsuite/ChangeLog:
2017-10-24  Pedro Alves  <palves@redhat.com>

	* gdb.threads/attach-into-signal.exp (corefunc): Don't SIGCONT
	test program before killing it.
---
 gdb/testsuite/gdb.threads/attach-into-signal.exp | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/gdb/testsuite/gdb.threads/attach-into-signal.exp b/gdb/testsuite/gdb.threads/attach-into-signal.exp
index 3158b59..0af9ed5 100644
--- a/gdb/testsuite/gdb.threads/attach-into-signal.exp
+++ b/gdb/testsuite/gdb.threads/attach-into-signal.exp
@@ -113,10 +113,6 @@ proc corefunc { threadtype executable } {
 	# Exit and detach the process.
 	gdb_exit
 
-	# Continue the program - some Linux kernels need it before -9 if the
-	# process is stopped.
-	remote_exec build "kill -s CONT ${testpid}"
-
 	kill_wait_spawned_process $test_spawn_id
     }
 }
-- 
2.5.5


      parent reply	other threads:[~2017-10-24 10:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23 14:18 [PATCH 0/6] Fix several cases of unstable test names Pedro Alves
2017-10-23 14:18 ` [PATCH 5/6] Fix unstable test names in gdb.threads/attach-into-signal.exp Pedro Alves
2017-10-23 14:18 ` [PATCH 3/6] Fix unstable test names in gdb.gdb/unittest.exp Pedro Alves
2017-10-23 14:18 ` [PATCH 2/6] Fix unstable test names in gdb.base/startup-with-shell.exp Pedro Alves
2017-10-23 16:24   ` Yao Qi
2017-10-24  9:58     ` Pedro Alves
2017-10-23 14:18 ` [PATCH 1/6] Fix unstable test names in gdb.arch/arc-tdesc-cpu.exp Pedro Alves
2017-10-23 14:18 ` [PATCH 4/6] Fix unstable test names in gdb.python/py-objfile.exp Pedro Alves
2017-10-23 14:28 ` [PATCH 6/6] Drop /proc/PID/status polling from gdb.threads/attach-into-signal.exp Pedro Alves
2017-10-24  7:27   ` Yao Qi
2017-10-24 10:00     ` [pushed] Reindent gdb.threads/attach-into-signal.exp (Re: [PATCH 6/6] Drop /proc/PID/status polling from gdb.threads/attach-into-signal.exp) Pedro Alves
2017-10-24 10:09     ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3c61796-3066-7753-f024-937ea2b2234a@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox