From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id e3dFGznC4Wc9vBkAWB0awg (envelope-from ) for ; Mon, 24 Mar 2025 16:36:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1742848569; bh=1M01FdfmUNqEz0sBHjaaWD9WQuM7Dzv3jSNDxsHF6Vs=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Zp/cjqvE+9ute+PsA2eNKBVdTOkHHVidz3ERTjItCwUIdNI0TOzzSWjvc2SR0soX2 ZQEgLfheTnUCWqYCDwwYwZJ84PzsGttS98AwpdWr1sK4LxrOL2OlLWfymPvxV7Zz1x skrZ6qemQWUsvHvgQbVv0NSWYh3ybo9k8ecstluQ= Received: by simark.ca (Postfix, from userid 112) id 594411E100; Mon, 24 Mar 2025 16:36:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=YcYOsVpD; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=tbraatPs; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 004C01E0C0 for ; Mon, 24 Mar 2025 16:36:05 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 89A9C385840B for ; Mon, 24 Mar 2025 20:35:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 89A9C385840B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=YcYOsVpD; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=tbraatPs Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id E4F873858D29 for ; Mon, 24 Mar 2025 20:31:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4F873858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E4F873858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742848268; cv=none; b=fsUECyrmiY4VckaTDSi0guehyjnon+QY3QYsIXscE3L4Y8hKOJlwlp1L0QeJ6P1VmVvSvo0Y0O0AKJ2baeTq0dx4ucyO4Y15195CGEFU+ZngaylUU5+X62NrHdwnOHsXFSK844a0xYPaHlzHoexU/9jvKBtwcBAxc6Vr1NJlvbY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742848268; c=relaxed/simple; bh=1M01FdfmUNqEz0sBHjaaWD9WQuM7Dzv3jSNDxsHF6Vs=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=a95+KCVOlUhpkn+MxtoRoC5H9sjPbmfMZneWMdw3FpxIrraSSLw53DXLH5BzbJGBnr3WmCCJg1teaVyveJ7xBg6OPaBPK20+WuW7r2MBLYXeTzp+b9oPsTkQdgw0h9vsknH+UFOS5Nd0BwpnA0d3l8Lf10LklWyNeYRkTQWp438= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E4F873858D29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1742848257; bh=1M01FdfmUNqEz0sBHjaaWD9WQuM7Dzv3jSNDxsHF6Vs=; h=Date:Subject:To:References:From:In-Reply-To:From; b=YcYOsVpDjW5sXPyndI2aRNjL5aKMZfVwFA1MRrRHfA3tL5tYx+Y9xM1CQAXRz3PZ1 UarJOYNyLghRiNOt56qBsPa448AlY2GxPAOdh/T1TxEuwPaXTFYVnTHKsyDwRSV3xP j/M1r/pipcsySS23OQ7qgqVSJDqvjydK1Y69pQ2U= Received: by simark.ca (Postfix, from userid 112) id 85FE71E100; Mon, 24 Mar 2025 16:30:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1742848256; bh=1M01FdfmUNqEz0sBHjaaWD9WQuM7Dzv3jSNDxsHF6Vs=; h=Date:Subject:To:References:From:In-Reply-To:From; b=tbraatPscEFzi/NFxyNLRtM8/qUcp0dosDg3/sHehedmHy4kWAjX9LYAdrnX3bhki zNDpv7ytK7Dh4JOPXBbJ6fkQwqZwtT45ZhM04jg20W7zPTKC+HcQJFaO2zITcLQmaC 5zK1d0io3L30rPSlqGa4E2MfB78K0MfqYwZwSKeM= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E76651E0C0; Mon, 24 Mar 2025 16:30:56 -0400 (EDT) Message-ID: Date: Mon, 24 Mar 2025 16:30:56 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] Remove 'read' call from dwz_file::read_string To: Tom Tromey , gdb-patches@sourceware.org References: <20250323-dwz-dwarf-5-v2-v1-0-3c0775ca5514@tromey.com> <20250323-dwz-dwarf-5-v2-v1-1-3c0775ca5514@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20250323-dwz-dwarf-5-v2-v1-1-3c0775ca5514@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-03-23 15:20, Tom Tromey wrote: > dwz_file::read_string calls 'read' on the section, but this isn't > needed as the sections have all been pre-read. In the long term, to remove unnecessary 'read' calls in a safe way, I was thinking of introducing some kind of 'dwarf2_read_section_info' type that would be a thin wrapper around a `dwarf2_section_info`, but one that you could only obtain by calling `dwarf2_section_info::read`. That would be a kind of "token" to make sure that the section is safe to read from. A bit like when a function accepts an std::lock_guard object, it is guaranteed that the lock is taken. > @@ -261,7 +263,7 @@ dwarf2_read_dwz_file (dwarf2_per_objfile *per_objfile) > error (_("could not find '.gnu_debugaltlink' file for %s"), > per_bfd->filename ()); > > - auto result = std::make_unique (std::move (dwz_bfd)); > + dwz_file_up result (new dwz_file (std::move (dwz_bfd))); Why this change? Otherwise, LGTM. Approved-By: Simon Marchi Simon