From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-134223-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 85421 invoked by alias); 20 Oct 2016 22:21:52 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 85412 invoked by uid 89); 20 Oct 2016 22:21:51 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:get_obj, Hx-languages-length:747
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Oct 2016 22:21:41 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 55E0D7F776;	Thu, 20 Oct 2016 22:21:40 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9KMLcVa013791;	Thu, 20 Oct 2016 18:21:39 -0400
Subject: Re: [RFA 2/2] Make some dwarf_expr_context methods pure virtual
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <1477000280-14921-1-git-send-email-tom@tromey.com> <1477000280-14921-3-git-send-email-tom@tromey.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <b37a65e4-c618-a3a5-d0c1-bd751db261ec@redhat.com>
Date: Thu, 20 Oct 2016 22:21:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <1477000280-14921-3-git-send-email-tom@tromey.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-10/txt/msg00634.txt.bz2

On 10/20/2016 10:51 PM, Tom Tromey wrote:
> This patch changes some dwarf_expr_context to be pure virtual, as
> mentioned during the discussion of an earlier patch in this series.
> 
> 2016-10-20  Tom Tromey  <tom@tromey.com>
> 
> 	* dwarf2expr.h (class dwarf_expr_context)
> 	<get_frame_base, get_frame_cfa, get_tls_address, dwarf_call,
> 	push_dwarf_block_entry_value, get_addr_index, get_object_address>:
> 	Now pure virtual.
> 	* dwarf2-frame.c (class dwarf_expr_executor)
> 	<get_frame_base, get_frame_cfa, get_tls_address, dwarf_call,
> 	push_dwarf_block_entry_value, get_addr_index, get_object_address>:
> 	New methods.
> 	<invalid>: New method.

Nice, thanks.  LGTM.

Thanks,
Pedro Alves