From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101988 invoked by alias); 29 Dec 2019 19:46:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101237 invoked by uid 89); 29 Dec 2019 19:45:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 spammy=UD:m, nov, HX-Languages-Length:2454, covers X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 29 Dec 2019 19:45:55 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 910C81E092; Sun, 29 Dec 2019 14:45:13 -0500 (EST) Subject: Re: [PATCHv2] Fix setting breakpoints or stepping on line 65535 To: Bernd Edlinger , Andrew Burgess Cc: "gdb-patches@sourceware.org" References: <20191201220818.GI3410@embecosm.com> From: Simon Marchi Message-ID: Date: Sun, 29 Dec 2019 19:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg01062.txt.bz2 On 2019-12-02 1:04 p.m., Bernd Edlinger wrote: > Hi Andrew, > > On 12/1/19 11:08 PM, Andrew Burgess wrote: >> * Bernd Edlinger [2019-11-24 11:54:23 +0000]: >> >>> Hi, >>> >>> this removes code that is present from the very first git revisison >>> 7b4ac7e1ed2c4616bce56d1760807798be87ac9e from 1988. It was in the >>> gdb/dbxread.c at the time (and makes more sense for dbx line info format >>> since line numbers are 16-bit entities in that debug format and debugging >>> files with more than 65535 lines would not work anyway) but moved from >>> there to gdb/buildsym.c which is used for dwarf line info as well, and >>> excluding an arbitrary line number does certainly not make sense nowadays. >>> >>> >>> Thanks >>> Bernd. >> >>> From f202ae765b72ad6d17600eb661993a63191309f7 Mon Sep 17 00:00:00 2001 >>> From: Bernd Edlinger >>> Date: Sat, 23 Nov 2019 07:37:26 +0100 >>> Subject: [PATCH 1/2] Fix setting breakpoints or stepping on line 65535 >>> >> >> Bernd, >> >> Thanks for looking into this, and especially thanks for adding a test! >> >> Normally you should include the git commit message and ChangeLog along >> with your patch submission so that these can be reviewed too. 'git >> format-patch' and 'git send-email' can be useful for this, if you can >> get them setup. >> > > Okay, I added changelog messages for gdb/ChangeLog and gdb/testsuite/ChangeLog, > and improved the commit messages. > I hope you can handle the format-patch files as attachments. > >> Given the age of the code you're removing I think this change sounds >> reasonable. I assume there's no test that covers why this code should >> be there, so you see no regressions with this code removed? >> > > No, there were no regressions (last full test on 24-11-19). > >> I have a couple of minor issues with the test. If you address those >> and repost with commit message and ChangeLog this can be approved. >> > > Fixed the test. > > Thanks a lot for your review. > Is it OK for trunk? Thanks Bernd, this is OK. For the future, I think it would be reasonable to put the fix and the test in the same patch. It would also help somebody wondering why we have such a weird test trace it back to the fix, and the explanation you have put in the first patch. But it's also fine like this. I don't remember, do you have an account to push patches now? Simon