From: Pedro Alves <palves@redhat.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix spurious FAILs with examine-backward.exp
Date: Mon, 20 Mar 2017 17:34:00 -0000 [thread overview]
Message-ID: <b35b3643-bfec-5bbc-da47-44155022811e@redhat.com> (raw)
In-Reply-To: <m3wpbjc1l5.fsf@oc1027705133.ibm.com>
On 03/20/2017 05:14 PM, Andreas Arnez wrote:
> The test case examine-backward.exp issues the command "x/-s" after the end
> of the first string in TestStrings, but without making sure that this
> string is preceded by a string terminator. Thus GDB may spuriously print
> some random characters from before that string, and then the test fails.
>
> This patch assures that TestStrings is preceded by a string terminator.
>
Agreed. Looks like I forgot to follow through with:
https://sourceware.org/ml/gdb-patches/2016-08/msg00127.html
>
> +const char Barrier[] = {
> + 0x00,
> +};
> +
OK with a comment. Feel free to steal mine from that url.
> const char TestStrings[] = {
> 0x41, 0x42, 0x43, 0x44, 0x45, 0x46, 0x47, 0x48,
> 0x49, 0x4a, 0x4b, 0x4c, 0x4d, 0x4e, 0x4f, 0x50,
>
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-03-20 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 17:14 Andreas Arnez
2017-03-20 17:34 ` Pedro Alves [this message]
2017-03-20 17:57 ` Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b35b3643-bfec-5bbc-da47-44155022811e@redhat.com \
--to=palves@redhat.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox