From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127221 invoked by alias); 28 Sep 2017 22:11:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127040 invoked by uid 89); 28 Sep 2017 22:11:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=seconded X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Sep 2017 22:11:13 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 947EE4E4C3; Thu, 28 Sep 2017 22:11:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 947EE4E4C3 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id F08B4183E5; Thu, 28 Sep 2017 22:11:08 +0000 (UTC) Subject: Re: [RFA 00/12] some minor cleanup removals To: Sergio Durigan Junior , Tom Tromey References: <20170928195011.27382-1-tom@tromey.com> <87poaalelw.fsf@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Thu, 28 Sep 2017 22:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87poaalelw.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00892.txt.bz2 On 09/28/2017 10:04 PM, Sergio Durigan Junior wrote: > On Thursday, September 28 2017, Tom Tromey wrote: > >> This removes a number of cleanups, generally string related. >> >> I introduced string_vprintf to allow the use of std::string in some of >> these patches. >> >> The final patch just removes a couple of unused declarations; I would >> have checked it in as obvious, but it was more convenient to just >> leave it in this series. > > FWIW, I looked at the patches and they seem OK to me. > > Thanks for doing all these cleanups! Seconded! I sent a few comments, but overall it looks good to me too. Thanks, Pedro Alves