From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 1dJ4EfoYbGIhVgMAWB0awg (envelope-from ) for ; Fri, 29 Apr 2022 12:57:30 -0400 Received: by simark.ca (Postfix, from userid 112) id 34EDA1E058; Fri, 29 Apr 2022 12:57:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A,RDNS_DYNAMIC autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8887D1E00D for ; Fri, 29 Apr 2022 12:57:29 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4B4093857C4A for ; Fri, 29 Apr 2022 16:57:28 +0000 (GMT) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by sourceware.org (Postfix) with ESMTPS id 5D6263858D1E for ; Fri, 29 Apr 2022 16:57:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5D6263858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f44.google.com with SMTP id b19so11523827wrh.11 for ; Fri, 29 Apr 2022 09:57:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/PjC3HG7cfborym33DRQsvX9WBpjeeDnNx0D0PMVe30=; b=vWa6J/0hAktfOBMhqSoxlf4FRWT1h6JkzHP4gCdGTgsHw8emgC3bQOBJ6rteHifSIh 0IYdS3C2JfdP/7bwRMhrYmLsi4PE1bPYxvi3f+m94IE58zR3/QSTvMp47YlQzqz8SJcL Xp11h7+RM2UyJ0jwSHLch5pFsPc+TqQY0gKgrRYR8ZPQTvno+Lqealt4D8RGKNEZ30kf Ag9mrdCOtcYzpVnu8VN7BxMZDEixsV1pF/043JdQvIHyk82AIoA8fuhRCFokKthK3vVM hjVe48ijp7ZIA+ZWZk4OK9OgkVCTY5OWtBHZRIWNUGxi9ZIqagNJN3RhyswX1vKcZ26a WOkA== X-Gm-Message-State: AOAM533XYlSwsJgDKAVDgiJaipmdQL57/aF45dM5omrWWK8Hxq5KtH37 1wYYJGIgHJqjaw8HxUQyga0= X-Google-Smtp-Source: ABdhPJyTiGXnnffLHZDI85BGbYfo52ozGkBwwVttUxXOf8vJhDzAkltaMPXk7cpqzKR4vUIgCZTgQA== X-Received: by 2002:a05:6000:10a:b0:20a:e2aa:6848 with SMTP id o10-20020a056000010a00b0020ae2aa6848mr50939wrx.464.1651251435100; Fri, 29 Apr 2022 09:57:15 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id k7-20020a5d5247000000b0020c4a8d5487sm2130089wrc.18.2022.04.29.09.57.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Apr 2022 09:57:14 -0700 (PDT) Message-ID: Date: Fri, 29 Apr 2022 17:57:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] Fix gdb.cp/no-dmgl-verbose.exp test Content-Language: en-US To: Carl Love , Lancelot SIX References: <5ee342cd5f5272da9970da8a077c2c5209b85d6c.camel@us.ibm.com> <20220429091234.62xhprge74gfpgks@ubuntu.lan> <4610920e52ea1bbeb5181c970887eb7cfe344f1a.camel@us.ibm.com> From: Pedro Alves In-Reply-To: <4610920e52ea1bbeb5181c970887eb7cfe344f1a.camel@us.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulrich Weigand , gdb-patches@sourceware.org, Rogerio Alves Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022-04-29 16:48, Carl Love via Gdb-patches wrote: > On Fri, 2022-04-29 at 09:14 +0000, Lancelot SIX wrote: > OK, I added the new test. It works as expected on PowerPC and on my > Intel system. > > (gdb) PASS: gdb.cp/no-dmgl-verbose.exp: info types ^std::string$ > break f(std::__cxx11::basic_string, std::allocator >) > > Breakpoint 1 at 0x10: file /home/carll/GDB/build-current/gdb/testsuite/../../../binutils-gdb-current/gdb/testsuite/gdb.cp/no-dmgl-verbose.cc, line 23. > > The additional test is good to have. > > The above suggested changes were tested on both PowerPC and Intel and > pass as expected. > > Please let me know if the updated patch looks ok. Thanks. So the file is called gdb.cp/no-dmgl-verbose.exp. "no-dmgl" most certainly means "no demangle". However, the intro comment says: # Test loading symbols from unrelocated C++ object files. and indeed, the testcase only compiles an object: if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}.o" object {c++ debug}] != "" } { untested "failed to compile" return -1 } ... and loads that into gdb: clean_restart ${testfile}.o How is that related to "no demangle verbose" ? A mystery. OK. Now, if we're not going to be testing that setting a breakpoint via the typedef, like "b f(std::string)", WORKS (I thought GDB had code to make that work, why doesn't it?), then what's the point of the test? Testing that the breakpoint set at the non-typedef expansion of std::string is really no different from setting a breakpoint at any other C++ function, so we could eliminate the std::string dependency. It seems like something is missing here. What did the original submission of the patch that added the test say?