From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21810 invoked by alias); 13 Feb 2011 13:40:45 -0000 Received: (qmail 21801 invoked by uid 22791); 13 Feb 2011 13:40:44 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-vbr8.xs4all.nl (HELO smtp-vbr8.xs4all.nl) (194.109.24.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 13 Feb 2011 13:40:40 +0000 Received: from webmail.xs4all.nl (dovemail15.xs4all.nl [194.109.26.17]) by smtp-vbr8.xs4all.nl (8.13.8/8.13.8) with ESMTP id p1DDeR4H094941; Sun, 13 Feb 2011 14:40:28 +0100 (CET) (envelope-from mark.kettenis@xs4all.nl) Received: from 83.163.83.176 (SquirrelMail authenticated user sibelius) by webmail.xs4all.nl with HTTP; Sun, 13 Feb 2011 14:40:32 +0100 Message-ID: In-Reply-To: <4D57AB12.1050708@codesourcery.com> References: <4D57AB12.1050708@codesourcery.com> Date: Sun, 13 Feb 2011 13:40:00 -0000 Subject: Re: [patch] Move common macros to i386-common.h From: "Mark Kettenis" To: "Yao Qi" Cc: gdb-patches@sourceware.org User-Agent: SquirrelMail/1.4.18 MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00246.txt.bz2 > Some macros are duplicated in gdb/i386-nat and gdb/gdbserver/i386-low. > This patch is to move common macros to gdb/common/i386-common.h. > > There are also some duplicated functions, which should be moved in next > step. I'm just back from a 3+-week holiday. I'm not buying into the "share more stuff between gdb and gdbserver" mantra yet. Please hold off on this until I've gotten caught up with my mail and had a chance to think about all this. Thanks, Mark