From: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
To: gdb-patches@sourceware.org
Subject: [PING][PATCH, master+11][gdb/build] Add CXX_DIALECT to CXX
Date: Tue, 21 Sep 2021 01:04:19 +0200 [thread overview]
Message-ID: <b320f66d-35e6-729f-62d9-d14de2b06fa4@suse.de> (raw)
In-Reply-To: <20210908121519.GA17723@delia>
On 9/8/21 2:15 PM, Tom de Vries wrote:
> Hi,
>
> The problem reported in PR28318 is that when using a gcc version that (while
> supporting c++11) does not support c++11 by default, the configure test for
> std::thread support will fail.
>
> If gdb would use the default AX_CXX_COMPILE_STDCXX from autoconf, then we'd
> have:
> ...
> CXX="g++ -std=gnu++11"
> ...
> and the test for std::thread support would succeed.
>
> Instead, gdb uses a custom AX_CXX_COMPILE_STDCXX (see commit 0bcda685399)
> which does:
> ...
> CXX=g++
> CXX_DIALECT=-std=gnu++11
> ...
>
> We could add $CXX_DIALECT to the test for std::thread support, but that would
> have to be repeated for each added c++ support test.
>
> Instead, fix this by doing:
> ...
> CXX="g++ -std=gnu++11"
> CXX_DIALECT=-std=gnu++11
> ...
>
> The code added in gdb/ax_cxx_compile_stdcxx.m4 is copied from the default
> AX_CXX_COMPILE_STDCXX from autoconf.
>
> Tested on x86_64-linux.
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28318
>
> Any comments?
>
Ping.
Thanks,
- Tom
> [gdb/build] Add CXX_DIALECT to CXX
>
> ---
> gdb/ax_cxx_compile_stdcxx.m4 | 8 ++++++++
> gdb/configure | 8 ++++++++
> gdbserver/configure | 8 ++++++++
> gdbsupport/configure | 8 ++++++++
> 4 files changed, 32 insertions(+)
>
> diff --git a/gdb/ax_cxx_compile_stdcxx.m4 b/gdb/ax_cxx_compile_stdcxx.m4
> index 413755a2e88..29d8e10bcc4 100644
> --- a/gdb/ax_cxx_compile_stdcxx.m4
> +++ b/gdb/ax_cxx_compile_stdcxx.m4
> @@ -94,6 +94,10 @@ AC_DEFUN([AX_CXX_COMPILE_STDCXX], [dnl
> CXX="$ac_save_CXX"])
> if eval test x\$$cachevar = xyes; then
> CXX_DIALECT="$switch"
> + CXX="$CXX $switch"
> + if test -n "$CXXCPP" ; then
> + CXXCPP="$CXXCPP $switch"
> + fi
> ac_success=yes
> break
> fi
> @@ -118,6 +122,10 @@ AC_DEFUN([AX_CXX_COMPILE_STDCXX], [dnl
> CXX="$ac_save_CXX"])
> if eval test x\$$cachevar = xyes; then
> CXX_DIALECT="$switch"
> + CXX="$CXX $switch"
> + if test -n "$CXXCPP" ; then
> + CXXCPP="$CXXCPP $switch"
> + fi
> ac_success=yes
> break
> fi
> diff --git a/gdb/configure b/gdb/configure
> index f0b1af4a6ea..98badb46cfd 100755
> --- a/gdb/configure
> +++ b/gdb/configure
> @@ -5841,6 +5841,10 @@ eval ac_res=\$$cachevar
> $as_echo "$ac_res" >&6; }
> if eval test x\$$cachevar = xyes; then
> CXX_DIALECT="$switch"
> + CXX="$CXX $switch"
> + if test -n "$CXXCPP" ; then
> + CXXCPP="$CXXCPP $switch"
> + fi
> ac_success=yes
> break
> fi
> @@ -6160,6 +6164,10 @@ eval ac_res=\$$cachevar
> $as_echo "$ac_res" >&6; }
> if eval test x\$$cachevar = xyes; then
> CXX_DIALECT="$switch"
> + CXX="$CXX $switch"
> + if test -n "$CXXCPP" ; then
> + CXXCPP="$CXXCPP $switch"
> + fi
> ac_success=yes
> break
> fi
> diff --git a/gdbserver/configure b/gdbserver/configure
> index b227167e270..f05c1a9b976 100755
> --- a/gdbserver/configure
> +++ b/gdbserver/configure
> @@ -5625,6 +5625,10 @@ eval ac_res=\$$cachevar
> $as_echo "$ac_res" >&6; }
> if eval test x\$$cachevar = xyes; then
> CXX_DIALECT="$switch"
> + CXX="$CXX $switch"
> + if test -n "$CXXCPP" ; then
> + CXXCPP="$CXXCPP $switch"
> + fi
> ac_success=yes
> break
> fi
> @@ -5944,6 +5948,10 @@ eval ac_res=\$$cachevar
> $as_echo "$ac_res" >&6; }
> if eval test x\$$cachevar = xyes; then
> CXX_DIALECT="$switch"
> + CXX="$CXX $switch"
> + if test -n "$CXXCPP" ; then
> + CXXCPP="$CXXCPP $switch"
> + fi
> ac_success=yes
> break
> fi
> diff --git a/gdbsupport/configure b/gdbsupport/configure
> index a9dd02c5b72..ae6047865ae 100755
> --- a/gdbsupport/configure
> +++ b/gdbsupport/configure
> @@ -6520,6 +6520,10 @@ eval ac_res=\$$cachevar
> $as_echo "$ac_res" >&6; }
> if eval test x\$$cachevar = xyes; then
> CXX_DIALECT="$switch"
> + CXX="$CXX $switch"
> + if test -n "$CXXCPP" ; then
> + CXXCPP="$CXXCPP $switch"
> + fi
> ac_success=yes
> break
> fi
> @@ -6839,6 +6843,10 @@ eval ac_res=\$$cachevar
> $as_echo "$ac_res" >&6; }
> if eval test x\$$cachevar = xyes; then
> CXX_DIALECT="$switch"
> + CXX="$CXX $switch"
> + if test -n "$CXXCPP" ; then
> + CXXCPP="$CXXCPP $switch"
> + fi
> ac_success=yes
> break
> fi
>
next prev parent reply other threads:[~2021-09-20 23:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 12:15 [PATCH, " Tom de Vries via Gdb-patches
2021-09-20 23:04 ` Tom de Vries via Gdb-patches [this message]
2021-09-23 14:27 ` Simon Marchi via Gdb-patches
2021-09-23 14:33 ` Pedro Alves
2021-09-27 12:59 ` Tom de Vries via Gdb-patches
2021-10-04 13:58 ` Tom de Vries via Gdb-patches
2021-10-04 16:16 ` Simon Marchi via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b320f66d-35e6-729f-62d9-d14de2b06fa4@suse.de \
--to=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox