From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KrDYNrDvWWPyDxEAWB0awg (envelope-from ) for ; Wed, 26 Oct 2022 22:40:48 -0400 Received: by simark.ca (Postfix, from userid 112) id D451B1E11A; Wed, 26 Oct 2022 22:40:48 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=ehW/E8ZS; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 883AA1E0D5 for ; Wed, 26 Oct 2022 22:40:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 56CB3382A2C0 for ; Thu, 27 Oct 2022 02:40:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 56CB3382A2C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666838447; bh=gUlDYUT4U08s0qNjnIg7IJinpOPMUiq7fp4wGpPF9kw=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ehW/E8ZSLXBhvf3tIbt9MMa6cNOxEJWMZK0F6VcNXqEopkXzgDhJQeY3EASq5HaEe E9w/EIbxcsdB1cjKw0Uc6vsgnYV6N4q5clrAAZ+aSAet+o5uiwWc47aa6Aonm+Ktw9 tR/3EydsaEaYS8mc8G65kquxGUyoaswzDtDvnIi4= Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 26E0D382EA14 for ; Thu, 27 Oct 2022 02:40:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 26E0D382EA14 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 26969300089; Thu, 27 Oct 2022 02:40:25 +0000 (UTC) Message-ID: Date: Thu, 27 Oct 2022 11:40:22 +0900 Mime-Version: 1.0 Subject: Re: [PATCH 22/40] sim/m32r: Fixes to Linux emulator Content-Language: en-US To: Mike Frysinger , gdb-patches@sourceware.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tsukasa OI via Gdb-patches Reply-To: Tsukasa OI Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022/10/23 23:56, Mike Frysinger wrote: > On 20 Oct 2022 09:32, Tsukasa OI wrote: >> 1. Some header files were missing > > this looks fine > >> 2. syslog function must be called as a syscall rather than POSIX syslog >> because we are emulating Linux system calls on the Linux host. > > i don't think that is accurate. if that were true, every other call in here > would be using syscall() instead of calling the C library functions. Note that this part is a Linux to Linux syscall translator (though I consider this whole idea unsafe). Yes, it uses many C library functions but I consider this is because they are (almost/completely) compatible with underlying syscalls. However, this isn't the case for syslog. POSIX syslog (C library function on ) and Linux syslog (syscall) have very different semantics and Linux syslog should be used here. Probably using glibc wrapper klogctl () might be a solution (see man page syslog.2). I would like to hear your thoughts. Best regards, Tsukasa > >> 3. ftime function is deprecated but used intentionally. >> We have to disable deprecated function warning. > > this looks fine > -mike