From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9752 invoked by alias); 24 Apr 2018 16:43:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9737 invoked by uid 89); 24 Apr 2018 16:43:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:658 X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Apr 2018 16:43:27 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 21F26818535F; Tue, 24 Apr 2018 16:43:26 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id A281F215CDC8; Tue, 24 Apr 2018 16:43:25 +0000 (UTC) Subject: Re: [RFA 4/8] Constify prompt argument to read_command_lines To: Tom Tromey , gdb-patches@sourceware.org References: <20180419191539.661-1-tom@tromey.com> <20180419191539.661-5-tom@tromey.com> From: Pedro Alves Message-ID: Date: Tue, 24 Apr 2018 16:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180419191539.661-5-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-04/txt/msg00478.txt.bz2 On 04/19/2018 08:15 PM, Tom Tromey wrote: > The prompt argument to read_command_lines can be const. This patch > makes this change, and also removes some fixed-sized buffers in favor > of using string_printf. > > 2018-04-19 Tom Tromey > > * tracepoint.c (actions_command): Update. > * cli/cli-script.h (read_command_lines): Update. > * cli/cli-script.c (read_command_lines): Constify prompt_arg. > (MAX_TMPBUF): Remove define. > (define_command): Use string_printf. > (document_command): Likewise. > * breakpoint.c (commands_command_1): Update. Looks good. Thanks, Pedro Alves