From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /VZDD7tynWTsHhEAWB0awg (envelope-from ) for ; Thu, 29 Jun 2023 08:02:03 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=VGkiR4n5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 305AD1E0BB; Thu, 29 Jun 2023 08:02:03 -0400 (EDT) Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1CD2D1E00F for ; Thu, 29 Jun 2023 08:02:01 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 733A03858408 for ; Thu, 29 Jun 2023 12:02:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 733A03858408 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1688040120; bh=y2GS1LX7DO1vy4CVlK202opd2olulkmQkrG/hk8qNtM=; h=Date:Subject:To:References:Cc:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=VGkiR4n5ldBStNj4XvOwCTtLp940kvi/VjnU18yOre1W1/bABp7MogfmTnwMBVYIw IJcSPVfoKXDGuEpYFzCB62ib0viyY9+wzf25poDcvj9yV3jS7xX/ngcc5cC8mMVUiQ vaRHewXPFQ4REpuxis91vBvXhTTGL70iZ/Tw5Vrc= Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by sourceware.org (Postfix) with ESMTPS id D4F633858C39 for ; Thu, 29 Jun 2023 12:01:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D4F633858C39 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b698dd515dso8394681fa.3 for ; Thu, 29 Jun 2023 05:01:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688040098; x=1690632098; h=content-transfer-encoding:in-reply-to:from:cc:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y2GS1LX7DO1vy4CVlK202opd2olulkmQkrG/hk8qNtM=; b=Mc32CFBBZkavOSNQ50iSTNFYc7AkmqvhU/43fE2/FAIOSDO4N5bIWwsQNLH7BfU1+t 2BY4vpuEIORkabxIIdHN8JpqMNUDB56lCzXUVUFOsw02gbeSjCJHno7aphi+G1RMcCZE OCxmWrPnxQDIii0IpimbLNA/0SABiUcTz0ntc4b3oyr0B0bU1h3eOfD0Y6NMvANXjQL+ vbrZ2J3l4UBxdoTbd3rKzRS9Y7kTViwwQcxZU7bUKstzB874jN5zoT38ZO/pAjnMQgFg 6sddhkgN9t0H3XQ9QXtL86r9z/0PZjxo9rC2R0qLskb3jwG4OThPD+eOkXBAzFYJ2NgR ksag== X-Gm-Message-State: AC+VfDwG30+D8RpfJfwfrIfKabDr7+xPmSAnemhux87p0UVVfsVNOZl8 aZ6q5auODLYpIGa9Gvv9pO6lBGJpHb4= X-Google-Smtp-Source: ACHHUZ5vg3MM6/dV9DsrQk+G8PG3VFp9Gn6xj5U8KZnAgJCn67wEoqwveDXopilZQ8Fj+ivTzZw3Cg== X-Received: by 2002:a2e:96d5:0:b0:2b6:98df:3630 with SMTP id d21-20020a2e96d5000000b002b698df3630mr9570183ljj.51.1688040097904; Thu, 29 Jun 2023 05:01:37 -0700 (PDT) Received: from [192.168.1.20] (78-73-77-63-no2450.tbcn.telia.com. [78.73.77.63]) by smtp.gmail.com with ESMTPSA id l6-20020a2e7006000000b002b61fc91050sm2590183ljc.50.2023.06.29.05.01.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jun 2023 05:01:37 -0700 (PDT) Message-ID: Date: Thu, 29 Jun 2023 14:01:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1] gdb/DAP - Add completionsRequest To: Lancelot SIX References: <20230628162616.102268-1-simon.farre.cx@gmail.com> <20230629083251.2aglieoblj2jw25l@octopus> Content-Language: en-US Cc: gdb-patches@sourceware.org In-Reply-To: <20230629083251.2aglieoblj2jw25l@octopus> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Farre via Gdb-patches Reply-To: Simon Farre Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Hi Simon, > > Instead of filtering out this message, would it make sense to allow GDB > to list all possible completions without size limit? > > This can be done with: > > cmd_output = gdb.execute("with max-completions unlimited -- complete " + text, > to_string=True) > > I am not very familiar with the DAP protocol, but looking at it I did > not see a mechanism to limit the number of items returned, or a way for > GDB to let the client know that more options are available. Is there a > way to do this? That is a great idea, I had no idea that it could be done like that. Like you said, unfortunately (for some reason) a "max count" is not provided by the request in the protocol. I'll fix this in v2 and for good measure throw in tests for the request as well. Thanks for your input!