From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hRYJDLKb7WZmfjEAWB0awg (envelope-from ) for ; Fri, 20 Sep 2024 11:58:42 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=KVYHzOFt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1E8AA1E353; Fri, 20 Sep 2024 11:58:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-12.8 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 69EDF1E05C for ; Fri, 20 Sep 2024 11:58:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F33823858C39 for ; Fri, 20 Sep 2024 15:58:40 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 98C7A3858D29 for ; Fri, 20 Sep 2024 15:58:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 98C7A3858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 98C7A3858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726847904; cv=none; b=FNM2RfR4wo9GZE/hjY5GmXy6HueYRkcCB3bLzn9wV52yhsL2fNFvjEEjDGJHY1ACmP8z+5ZWAbXtMzSlnKu7NV7qMCd91JayFWqhNAIvHGtQfxNuQVnBkVUVe7FeYb0RPW6h9nBdTPByKrvdq1nbT1R9BhZaoq0G3z45OA037Y8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726847904; c=relaxed/simple; bh=Jx19QuDcHR0eGKc491NhyqxcbDI7f0CUHCioDSEo4lA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=mgyPRCxYs4spwTQBH3fwXFqcynsvqlW2GpIwdtIPsZARjS9uqMYjNANJcVITtzpIJwxGXyjZ61gVMj3uGfrgB2xXevdAh3/8WubUXNdwib33etUqV3nFCVeEpFN60c8iKMpCZOuZNxSMFbLxUltuKTjlEuaWL62WV89TjbBJHGo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726847902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K+853ZoV2nSnTP/92wUsShHM0HNPg6zWZbs41MkSyfw=; b=KVYHzOFtsYuQ/YVSs+bcIfQl4oB9qewF0LKvTSKOtvTxX7JTud2MgB6zpJ1Vw6gDgOSPmh HyulRCAQF1JXk3ZZ1E2b04ThVTQwywIABAO3Yt3/t2veRu6CGKcTZl6pGcNBR39SXFP7di 04WexhZvPfaSFozvBobXaWMZ9ck+nEk= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-DsvoEbZ4NdipU5hF8JkK2g-1; Fri, 20 Sep 2024 11:58:21 -0400 X-MC-Unique: DsvoEbZ4NdipU5hF8JkK2g-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-2d8a1e91afaso2166543a91.1 for ; Fri, 20 Sep 2024 08:58:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726847900; x=1727452700; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K+853ZoV2nSnTP/92wUsShHM0HNPg6zWZbs41MkSyfw=; b=Koip4Ay1yW965is7MZd04DPMaOZmysOvpBvYD0aR+0jXcU6/sYon0uYRVjTXk2Zgad wQe7fOk9uMmkfCAesCKmPazjSgeAmc8mkmKGE3runiwSMEYijUYdDjEE5nX69iyKrxSQ Hws/2pQSrB112T/h71yZC/K/elYA8flA1aHi62GhyeMycYbzlEmHlRxCob/b3NE2R8ML GrYk5SbaXao7SiRReixv8Rtf99/gfZ+kpBty6WjVs2evpEw+PiLnfak1PVCvndhYRcQf F6Q8mS1qn7CrdEo08E9aUID0tF5ZtxQQOpv2V9J86WsyGzvcsFeFEf1i+FxRdevTBwMZ HKiQ== X-Forwarded-Encrypted: i=1; AJvYcCWSJu9W2wLvbi+xQX3EweQ8YRl2gjVPGMfIBtPXyidrV4zBgPohwQvj1v1GgofISl9eXwKxR84xekym/Q==@sourceware.org X-Gm-Message-State: AOJu0Ywz11r01bv8QY4y1i8m/h0WPPFe7XhrwGzBEaQERcQ1/c3t7Lxf M41t/ZXJ1zTt4SFXteEAIVo0t4+uI2k/Tiu5BAdsCTvbB2LcNY0tZ9yQAy/mLFkM4Z+1GJM2Zzy plBRriAa+/ED5fP3smsLhtGJ48GwEtjjCfe65R9VFRJuNCpse2bl6BS7qPB+MUPN1PgM= X-Received: by 2002:a17:90b:4a8a:b0:2d8:8eee:ccab with SMTP id 98e67ed59e1d1-2dd80c4eea6mr3372229a91.22.1726847900250; Fri, 20 Sep 2024 08:58:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHgVRmUQZnK3ffmQMAh+hCGUHlfN0BLA4N2buZdjgb2TCfRh64YZh83ZeQHcC/1v8G9Gfcf2A== X-Received: by 2002:a17:90b:4a8a:b0:2d8:8eee:ccab with SMTP id 98e67ed59e1d1-2dd80c4eea6mr3372214a91.22.1726847899905; Fri, 20 Sep 2024 08:58:19 -0700 (PDT) Received: from [150.1.200.127] (174-21-139-113.tukw.qwest.net. [174.21.139.113]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2dd6ee7f5ffsm4308734a91.12.2024.09.20.08.58.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Sep 2024 08:58:19 -0700 (PDT) Message-ID: Date: Fri, 20 Sep 2024 08:58:18 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: rework bp-cond-failure to not depend on inlining To: Guinevere Larsen , gdb-patches@sourceware.org References: <20240919124204.1465834-1-blarsen@redhat.com> <1940030f-122d-4656-a293-44e5b5a98c92@redhat.com> From: Keith Seitz In-Reply-To: <1940030f-122d-4656-a293-44e5b5a98c92@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/20/24 8:56 AM, Guinevere Larsen wrote: > On 9/20/24 12:35 PM, Keith Seitz wrote: >> >> For the casual visitor to this file that has often been burned by >> hard-coded line numbers or locations, it would, at least, save me some >> grief. > At the top of the exp file, the comment that explains the purpose of the > test ends with the following: > > # We check that the correct breakpoint number appears in the error > # message, and that the error is reported at the correct source > # location. > > Would you still like me to add the comment in context, or do you think > that is enough? Okay, fully optional now, but please consider adding a comment referring to that explanation, at least. Again, I missed it entirely. :-) Keith