Re: [patch] Allow to link with ncursesw

Pedro Alves
2017-09-26T15:27:06Z

On 09/25/2017 06:36 PM, John Baldwin wrote:
> On Friday, September 22, 2017 11:21:58 AM Pedro Alves wrote:
>>
>> On 09/21/2017 12:56 AM, John Baldwin wrote:

>> Thanks! If you could also confirm with the in-tree readline
>> as well (i.e., without --with-system-readline), that'd be great. The
>> original Python reports I linked at were about readline compiled against
>> ncurses and then something else linked against ncursesw, IIUC. I don't
>> know whether that might make a difference, but I guess it could, if
>> readline is compiled against some curses structure that ends up
>> mismatching with the called curses functions due to odd interposition
>> effects.
>>
>> If that causes a problem, then we may need to patch our local
>> readline copy matching gdb.
>>
>> Otherwise, if all is fine, then I think we've given this
>> due diligence and Matthias' patch is fine with me.
>
> This seems to work fine in my testing both in the port (which with this
> change now only links against libncursesw instead of both) and in my own
> builds (which do not use --with-system-readline).

Thanks much! I've merged the patch to master, then.

Thanks,
Pedro Alves