From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id y6MWH7kEMmF4CQAAWB0awg (envelope-from ) for ; Fri, 03 Sep 2021 07:19:21 -0400 Received: by simark.ca (Postfix, from userid 112) id 6E2581EE22; Fri, 3 Sep 2021 07:19:21 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 445831EDDB for ; Fri, 3 Sep 2021 07:19:19 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A182B384BC22 for ; Fri, 3 Sep 2021 11:19:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A182B384BC22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1630667957; bh=TxUqabbxeR7Opy3mx+NyLwK/HwwVODPmn8gJSkO9Udc=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=p9h23WSlCpqNSxxWH1Vwf6BHr/JppuayFQHXwwOtJJ7+4gNbmmgJUZfM+wQTxjlUO 4M8sOVz++CesEZJqFIsrzAXq7/k5PTyTsXNNOt30B1KDTYn/yp78um6w6AL9C48133 KeMXEmZh7vUVi+S+cXo4251gnnoElOMOPcyF3sp8= Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id E1A22385840F for ; Fri, 3 Sep 2021 11:18:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E1A22385840F Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 210CE22651 for ; Fri, 3 Sep 2021 11:18:58 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 13C8C13736 for ; Fri, 3 Sep 2021 11:18:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id BMvBA6IEMmE1GwAAGKfGzw (envelope-from ) for ; Fri, 03 Sep 2021 11:18:58 +0000 Subject: Re: [PATCH][gdb/testsuite] Reimplement complaints selftest as unittest To: gdb-patches@sourceware.org References: <20210902134249.GA25158@delia> Message-ID: Date: Fri, 3 Sep 2021 13:18:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210902134249.GA25158@delia> Content-Type: multipart/mixed; boundary="------------97A5E9A1E55AE57D5D151A9D" Content-Language: en-US X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" This is a multi-part message in MIME format. --------------97A5E9A1E55AE57D5D151A9D Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 9/2/21 3:42 PM, Tom de Vries wrote: > Something specific to the new unittest is that we check the output as well. > To this end, we add SELFTEST_OUTPUT and SELFTEST_EXPECTED_OUTPUT markers: I tried it in another way: capturing the output, which means there's no need for the testsuite to verify the output. Passes build & gdb.gdb/unittest.exp, currently doing full regression test run. Any comments? Thanks, - Tom --------------97A5E9A1E55AE57D5D151A9D Content-Type: text/x-patch; charset=UTF-8; name="0002-gdb-testsuite-Reimplement-gdb.gdb-complaints.exp-as-unittest.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="0002-gdb-testsuite-Reimplement-gdb.gdb-complaints.exp-as-uni"; filename*1="ttest.patch" [gdb/testsuite] Reimplement gdb.gdb/complaints.exp as unittest When building gdb with "-Wall -O2 -g -flto=auto", I run into: ... (gdb) call clear_complaints()^M No symbol "clear_complaints" in current context.^M (gdb) FAIL: gdb.gdb/complaints.exp: clear complaints ... The problem is that lto has optimized away the clear_complaints function and consequently the selftest doesn't work. Fix this by reimplementing the selftest as a unit test. Factor out two new functions: - void execute_fn_to_ui_file (struct ui_file *file, std::function fn); - std::string execute_fn_to_string (std::function fn, bool term_out); and use the latter to capture the complaints output. Tested on x86_64-linux. --- gdb/complaints.c | 52 ++++++++++++++++ gdb/gdbcmd.h | 26 +++++--- gdb/testsuite/gdb.gdb/complaints.exp | 117 ----------------------------------- gdb/top.c | 31 +++++++--- 4 files changed, 94 insertions(+), 132 deletions(-) diff --git a/gdb/complaints.c b/gdb/complaints.c index fecbcd74ce5..525a3a7eacf 100644 --- a/gdb/complaints.c +++ b/gdb/complaints.c @@ -21,6 +21,7 @@ #include "complaints.h" #include "command.h" #include "gdbcmd.h" +#include "gdbsupport/selftest.h" #include /* Map format strings to counters. */ @@ -74,6 +75,53 @@ complaints_show_value (struct ui_file *file, int from_tty, value); } +#if GDB_SELF_TEST +namespace selftests { + +/* Entry point for complaints unit tests. */ + +static void +test_complaints () +{ + std::unordered_map tmp; + scoped_restore reset_counters = make_scoped_restore (&counters, tmp); + scoped_restore reset_stop_whining = make_scoped_restore (&stop_whining, 2); + +#define CHECK_COMPLAINT(STR, CNT) \ + do \ + { \ + std::string output; \ + output = execute_fn_to_string ([]() { complaint (STR); }, false); \ + std::string expected \ + = _("During symbol reading: ") + std::string (STR "\n"); \ + SELF_CHECK (output == expected); \ + SELF_CHECK (counters[STR] == CNT); \ + } while (0) + +#define CHECK_COMPLAINT_SILENT(STR, CNT) \ + do \ + { \ + std::string output; \ + output = execute_fn_to_string ([]() { complaint (STR); }, false); \ + SELF_CHECK (output.empty ()); \ + SELF_CHECK (counters[STR] == CNT); \ + } while (0) + + CHECK_COMPLAINT ("maintenance complaint 0", 1); + CHECK_COMPLAINT ("maintenance complaint 0", 2); + CHECK_COMPLAINT_SILENT ("maintenance complaint 0", 3); + CHECK_COMPLAINT ("maintenance complaint 1", 1); + clear_complaints (); + CHECK_COMPLAINT ("maintenance complaint 0", 1); + +#undef CHECK_COMPLAINT +#undef CHECK_COMPLAINT_SILENT +} + + +} // namespace selftests +#endif /* GDB_SELF_TEST */ + void _initialize_complaints (); void _initialize_complaints () @@ -84,4 +132,8 @@ Set max number of complaints about incorrect symbols."), _("\ Show max number of complaints about incorrect symbols."), NULL, NULL, complaints_show_value, &setlist, &showlist); + +#if GDB_SELF_TEST + selftests::register_test ("complaints", selftests::test_complaints); +#endif /* GDB_SELF_TEST */ } diff --git a/gdb/gdbcmd.h b/gdb/gdbcmd.h index f541ebd92d2..27550c1faee 100644 --- a/gdb/gdbcmd.h +++ b/gdb/gdbcmd.h @@ -134,17 +134,29 @@ extern struct cmd_list_element *save_cmdlist; extern void execute_command (const char *, int); -/* Run execute_command for P and FROM_TTY. Capture its output into the - returned string, do not display it to the screen. The global BATCH_FLAG - will temporarily be set to true. When TERM_OUT is true the output is - collected with terminal behaviour (e.g. with styling). When TERM_OUT is - false raw output will be collected (e.g. no styling). */ +/* Run FN. Sends its output to FILE, do not display it to the screen. + The global BATCH_FLAG will be temporarily set to true. */ + +extern void execute_fn_to_ui_file (struct ui_file *file, std::function fn); + +/* Run FN. Capture its output into the returned string, do not display it + to the screen. The global BATCH_FLAG will temporarily be set to true. + When TERM_OUT is true the output is collected with terminal behaviour + (e.g. with styling). When TERM_OUT is false raw output will be collected + (e.g. no styling). */ + +extern std::string execute_fn_to_string (std::function fn, bool term_out); + +/* As execute_fn_to_ui_file, but run execute_command for P and FROM_TTY. */ -extern std::string execute_command_to_string (const char *p, int from_tty, - bool term_out); extern void execute_command_to_ui_file (struct ui_file *file, const char *p, int from_tty); +/* As execute_fn_to_string, but run execute_command for P and FROM_TTY. */ + +extern std::string execute_command_to_string (const char *p, int from_tty, + bool term_out); + extern void print_command_line (struct command_line *, unsigned int, struct ui_file *); extern void print_command_lines (struct ui_out *, diff --git a/gdb/testsuite/gdb.gdb/complaints.exp b/gdb/testsuite/gdb.gdb/complaints.exp deleted file mode 100644 index c70825b6623..00000000000 --- a/gdb/testsuite/gdb.gdb/complaints.exp +++ /dev/null @@ -1,117 +0,0 @@ -# Copyright 2002-2021 Free Software Foundation, Inc. - -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; either version 3 of the License, or -# (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program. If not, see . - -# This file was written by Andrew Cagney (cagney at redhat dot com), -# derived from xfullpath.exp (written by Joel Brobecker), derived from -# selftest.exp (written by Rob Savoye). - -load_lib selftest-support.exp - -if [target_info exists gdb,noinferiorio] { - verbose "Skipping because of no inferiorio capabilities." - return -} - -# Similar to gdb_test_stdio, except no \r\n is expected before -# $gdb_prompt in the $gdb_spawn_id. - -proc test_complaint {test inferior_io_re msg} { - global inferior_spawn_id gdb_spawn_id - global gdb_prompt - - set inferior_matched 0 - set gdb_matched 0 - - gdb_test_multiple $test $msg { - -i $inferior_spawn_id -re "$inferior_io_re" { - set inferior_matched 1 - if {!$gdb_matched} { - exp_continue - } - } - -i $gdb_spawn_id -re "$gdb_prompt $" { - set gdb_matched 1 - if {!$inferior_matched} { - exp_continue - } - } - } - - verbose -log "inferior_matched=$inferior_matched, gdb_matched=$gdb_matched" - gdb_assert {$inferior_matched && $gdb_matched} $msg -} - -proc test_initial_complaints { } { - # Unsupress complaints - gdb_test "set stop_whining = 2" - - gdb_test_no_output "set var \$cstr = \"Register a complaint\"" - - # Prime the system - gdb_test_stdio \ - "call complaint_internal (\$cstr)" \ - "During symbol reading: Register a complaint" - - # Re-issue the first message #1 - with_test_prefix "re-issue" { - gdb_test_stdio \ - "call complaint_internal (\$cstr)" \ - "During symbol reading: Register a complaint" - } - - # Add a second complaint, expect it - gdb_test_stdio \ - "call complaint_internal (\"Testing! Testing! Testing!\")" \ - "During symbol reading: Testing. Testing. Testing." - - return 0 -} - -# Check that nothing comes out when there haven't been any real -# complaints. Note that each test is really checking the previous -# command. - -proc test_empty_complaint { cmd msg } { - global gdb_prompt - global inferior_spawn_id gdb_spawn_id - - if {$gdb_spawn_id == $inferior_spawn_id} { - gdb_test_no_output $cmd $msg - } else { - set seen_output 0 - gdb_test_multiple $cmd $msg { - -i $inferior_spawn_id -re "." { - set seen_output 1 - exp_continue - } - -i $gdb_spawn_id "$gdb_prompt $" { - gdb_assert !$seen_output $msg - } - } - } -} - -proc test_empty_complaints { } { - - test_empty_complaint "call clear_complaints()" \ - "clear complaints" - - return 0 -} - -do_self_tests captured_command_loop { - test_initial_complaints - test_empty_complaints -} diff --git a/gdb/top.c b/gdb/top.c index 0c49f4f9eb4..7e95ed3969c 100644 --- a/gdb/top.c +++ b/gdb/top.c @@ -696,12 +696,10 @@ execute_command (const char *p, int from_tty) cleanup_if_error.release (); } -/* Run execute_command for P and FROM_TTY. Sends its output to FILE, - do not display it to the screen. BATCH_FLAG will be - temporarily set to true. */ +/* See gdbcmd.h. */ void -execute_command_to_ui_file (struct ui_file *file, const char *p, int from_tty) +execute_fn_to_ui_file (struct ui_file *file, std::function fn) { /* GDB_STDOUT should be better already restored during these restoration callbacks. */ @@ -724,22 +722,39 @@ execute_command_to_ui_file (struct ui_file *file, const char *p, int from_tty) scoped_restore save_stdtargerr = make_scoped_restore (&gdb_stdtargerr, file); - execute_command (p, from_tty); + fn (); } } /* See gdbcmd.h. */ std::string -execute_command_to_string (const char *p, int from_tty, - bool term_out) +execute_fn_to_string (std::function fn, bool term_out) { string_file str_file (term_out); - execute_command_to_ui_file (&str_file, p, from_tty); + execute_fn_to_ui_file (&str_file, fn); return std::move (str_file.string ()); } +/* See gdbcmd.h. */ + +void +execute_command_to_ui_file (struct ui_file *file, + const char *p, int from_tty) +{ + execute_fn_to_ui_file (file, [=]() { execute_command (p, from_tty); }); +} + +/* See gdbcmd.h. */ + +std::string +execute_command_to_string (const char *p, int from_tty, + bool term_out) +{ + return + execute_fn_to_string ([=]() { execute_command (p, from_tty); }, term_out); +} /* When nonzero, cause dont_repeat to do nothing. This should only be set via prevent_dont_repeat. */ --------------97A5E9A1E55AE57D5D151A9D--