From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pvEjJKwFbl9cIAAAWB0awg (envelope-from ) for ; Fri, 25 Sep 2020 10:58:52 -0400 Received: by simark.ca (Postfix, from userid 112) id 8B2621EF4B; Fri, 25 Sep 2020 10:58:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 04A741E509 for ; Fri, 25 Sep 2020 10:58:52 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9406C396ECFB; Fri, 25 Sep 2020 14:58:51 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 3F1E8398E48E for ; Fri, 25 Sep 2020 14:58:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3F1E8398E48E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id EEE5D1E509; Fri, 25 Sep 2020 10:58:48 -0400 (EDT) Subject: Re: [PATCH] Add a missing munmap_list move constructor To: Saagar Jha , gdb-patches@sourceware.org References: <883A80DB-0918-4BA6-B387-A54581BFEA42@saagarjha.com> <20200925070525.47993-1-saagar@saagarjha.com> From: Simon Marchi Message-ID: Date: Fri, 25 Sep 2020 10:58:48 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200925070525.47993-1-saagar@saagarjha.com> Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-09-25 3:05 a.m., Saagar Jha wrote: > compile_module attempts to request a move constructor, but because > munmap_list doesn't have one it gets implicitly deleted. This is an > warning on clang under -Wdefaulted-function-deleted (which is enabled by > default): > > In file included from compile/compile-object-load.c:21: > compile/compile-object-load.h:56:3: error: explicitly defaulted move constructor is implicitly deleted [-Werror,-Wdefaulted-function-deleted] > compile_module (compile_module &&other) = default; > ^ > compile/compile-object-load.h:86:22: note: move constructor of 'compile_module' is implicitly deleted because field 'munmap_list' has a deleted move constructor > struct munmap_list munmap_list; > ^ > compile/compile-object-load.h:30:28: note: 'munmap_list' has been explicitly marked deleted here > DISABLE_COPY_AND_ASSIGN (munmap_list); > ^ > > gdb/ChangeLog: > > * compile/compile-object-load.h: Give munmap_list a move > constructor. Thanks, I pushed it. FYI, I tweaked the ChangeLog entry to include the structure name in parenthesis: * compile/compile-object-load.h (struct munmap_list): Add explicitly-defined move constructor. Simon