From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yD3EK6JJ7mjZezEAWB0awg (envelope-from ) for ; Tue, 14 Oct 2025 09:01:22 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Vu0v6AqR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A15B21E047; Tue, 14 Oct 2025 09:01:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A8D831E047 for ; Tue, 14 Oct 2025 09:01:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 39DF1385AC20 for ; Tue, 14 Oct 2025 13:01:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 39DF1385AC20 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Vu0v6AqR Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 100F13857359 for ; Tue, 14 Oct 2025 13:00:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 100F13857359 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 100F13857359 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760446816; cv=none; b=CrO0InpKvbQXkq9wfQEJ8NHMw1DPnRkOZTjD3U60DHBixe+23GuKV76JjYBfMQ0mh9ogQGUXN+3fJ02eeHdCQ/BAe/xVuCz550Brpz53KF9zRksPFe3GwCx5gmb/KO/61LAWLXCta8XvuK21bnYPitgd6xqifV00zdJgF3rynEQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760446816; c=relaxed/simple; bh=9WJH+HiWKN6yFK/g6jggWqOtTV1d04fwSfeepZob6lo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=v7sWMJHDeXb9952Xc+ctRWCDEnyoDDZK1TdeaO+F7ubCWq13m5uVqUlKee8U6VeCfcUhAv0JBsWtEvc79xB6hcfJ35mw9KOUFZRKjv3qPmVv75K0Bk0zy9M8wuYIVnuiTU4kIveg24s2oifwspO2hWnl2ni9XKyIAfwA7JwwgSk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 100F13857359 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760446815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fqeKH3u0yxF0ZQMsmy7IRgRGE+D3KYJu/zpEmV2oO4o=; b=Vu0v6AqRblXBL8U1KnBHgNQKcylhlAinFEgOnmPgkdbBB+fX9XmECtJ8ZyYGWjEFFtDp83 PKlh3LygjKo15FPphBD/YsNsUwbckmriCiNogbekd6QrQ/FYahoD8mJBhxG6ztLgigMJ2Q IVdWaWbII/RPAxj9uR3h7b77hVbLhYw= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-683-IZb-SnxJPd2uIXIbK_FwiA-1; Tue, 14 Oct 2025 09:00:14 -0400 X-MC-Unique: IZb-SnxJPd2uIXIbK_FwiA-1 X-Mimecast-MFC-AGG-ID: IZb-SnxJPd2uIXIbK_FwiA_1760446813 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-28973df6a90so97898635ad.2 for ; Tue, 14 Oct 2025 06:00:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760446813; x=1761051613; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fqeKH3u0yxF0ZQMsmy7IRgRGE+D3KYJu/zpEmV2oO4o=; b=H5OcX571c86M/vF4ucYCCw7oTWKqyg9DPR7p/ISbuYc8PzteTrptuFQfSu08cFCmyF lxOMBRYPH9xyFC+It4Lm3kBHVkuiBVvAXV4a8fHzBex4+7ABA/xvRRhptu6Q0dPGhEno 4yk45e7pxUEPlsvNyp+CEhssvL5DOR7Jv6BPbVBIbeY4PvgODmte74JwLVLcltWCqkbV +Njx6RyFVn5WEsNz4hO0tEFn/QqOh59PnYWM5S+01A3qPdzI9PuNFXgg+zu4QFO9lT6Z A5EV06j0je+TSqntBMYsCu0GkF5Bm+2OoDbW+E2m135JVNOy3HH5PhiyLyLKnp8p8BCH vXsQ== X-Forwarded-Encrypted: i=1; AJvYcCWncqN03Z6dbaE5td6trjiWEDcIQYwKuZz7k2y3vFUIXoMAw2eDcwh5RtykBS8DgRvsQRwLeoOfiR0+TA==@sourceware.org X-Gm-Message-State: AOJu0YxNAVGzYAjNWko2mO9fmjuhxg9fI5ZS8wIpOfkOkb/mjM2nzBQl 5wg3fg1f4ocm2ejpZvDBlANemdsWp+N3kKTkhbpPK30m7zTQG8nAdVTH4QJ0kS/1FFcC2Nz3SXr tHZ7BQgPP7+rcTTfmJp0N/YKnaK7nqjwlg6QKUcBBd81AkoPI6XyW5pkkmgB0rLu066mtebo= X-Gm-Gg: ASbGncvqE56YjWomeZ0YyjtE3rlTL7H5vPzmZyaBZUzT3ECmzt+TGam4t2doFURrqHD NQDozPa9FbsvOwrE9dKXriklyphuCgdgUEATvFBk8sCmh68ze9umoCUW6/PiphQe7dwSfl3yCmD LaM+XbB8tLYuSyv+EVNWp2Fg7ynLFM2RZTz5lFF5h0Ru6BQPKBYgB1t0IVAAlTKCJIhRVSdi1Ym 0WfuFxOddAd3e4Qzxb0xv2iJ2s0k+O/O7cs8U0r2YOjz5FxH55FRO3CG0wDoNOei+DoRsHNgDEb f6+IZZgYFnHnu8vKT9Zvr8rG+FWj9i437c6AfHD48fShK4Px1n8M X-Received: by 2002:a17:903:3848:b0:261:e1c0:1c44 with SMTP id d9443c01a7336-290273ffd77mr318173545ad.40.1760446811180; Tue, 14 Oct 2025 06:00:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGrLTpDNs0hkdjKN4jBO2tKMjeZr/vXd3X9jrCbWY1wVZ6PkLFjGtYBe7d44XEyQqqf2AMRmw== X-Received: by 2002:a17:903:3848:b0:261:e1c0:1c44 with SMTP id d9443c01a7336-290273ffd77mr318171985ad.40.1760446809494; Tue, 14 Oct 2025 06:00:09 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1000? ([2804:14d:8084:9a69::1000]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29034deadbfsm164885475ad.4.2025.10.14.06.00.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Oct 2025 06:00:08 -0700 (PDT) Message-ID: Date: Tue, 14 Oct 2025 10:00:05 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Use gnulib c-ctype module, not To: Tom Tromey , gdb-patches@sourceware.org References: <20250806-gnulib-c-ctype-v1-0-10f33e9f22a4@adacore.com> From: Guinevere Larsen In-Reply-To: <20250806-gnulib-c-ctype-v1-0-10f33e9f22a4@adacore.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RuXX3uifBAZM9RZpHSk1ZFSTXgynV76jFV5OMExGTuA_1760446813 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/6/25 10:13 AM, Tom Tromey wrote: > This series changes gdb to use the gnulib c-ctype module rather than > or "safe-ctype.h". > > The rationale is mostly in patch #3. I do wonder if it would be > better to just add the casts everywhere. > > Regression tested on x86-64 Fedora 41. This doesn't cover > solib-rocm.c though. > > Signed-off-by: Tom Tromey This patch series causes compilation to fail when using clang to compile GDB in fedora rawhide. The errors look like this: /usr/bin/ld: gdbsupport/common-utils-ipa.o: in function `strtoulst(char const*, char const**, int)': /home/buildbot/buildbot/binutils-gdb-clang-fedrawhide-x86_64/build/gdbserver/../gdbsupport/common-utils.cc:256:(.text+0xa3d): undefined reference to `c_isalnum' /usr/bin/ld: /home/buildbot/buildbot/binutils-gdb-clang-fedrawhide-x86_64/build/gdbserver/../gdbsupport/common-utils.cc:256:(.text+0xb0a): undefined reference to `c_isalnum' clang++: error: linker command failed with exit code 1 (use -v to see invocation) I have no idea why the newest clang has this problem and no other compiler does, might be a bug, but regardless, it is causing the clang buildbot to stop working > --- > Tom Tromey (3): > Import the c-ctype module from gnulib > Use c-ctype.h (not safe-ctype.h) in gdb > Use gnulib c-ctype module in gdb > > gdb/aarch64-linux-tdep.c | 9 +- > gdb/ada-exp.y | 5 +- > gdb/ada-lang.c | 87 ++++---- > gdb/ada-lex.l | 23 +-- > gdb/ada-typeprint.c | 3 +- > gdb/ada-valprint.c | 5 +- > gdb/arm-linux-tdep.c | 9 +- > gdb/arm-tdep.c | 1 - > gdb/auto-load.c | 3 +- > gdb/break-catch-exec.c | 4 +- > gdb/break-catch-fork.c | 2 +- > gdb/break-catch-syscall.c | 3 +- > gdb/break-catch-throw.c | 3 +- > gdb/break-cond-parse.c | 4 +- > gdb/breakpoint.c | 7 +- > gdb/btrace.c | 5 +- > gdb/c-exp.y | 19 +- > gdb/c-lang.c | 11 +- > gdb/c-support.h | 10 +- > gdb/charset.c | 1 - > gdb/cli/cli-cmds.c | 16 +- > gdb/cli/cli-decode.c | 9 +- > gdb/cli/cli-dump.c | 1 - > gdb/cli/cli-option.c | 4 +- > gdb/cli/cli-script.c | 7 +- > gdb/cli/cli-setshow.c | 3 +- > gdb/cli/cli-utils.c | 27 ++- > gdb/coff-pe-read.c | 3 +- > gdb/coffread.c | 7 +- > gdb/completer.c | 2 +- > gdb/cp-name-parser.y | 11 +- > gdb/cp-support.c | 9 +- > gdb/d-exp.y | 22 +- > gdb/darwin-nat.c | 1 - > gdb/dictionary.c | 4 +- > gdb/disasm.c | 1 - > gdb/dwarf2/cooked-index-entry.c | 3 +- > gdb/dwarf2/index-common.c | 10 +- > gdb/dwarf2/read.c | 4 +- > gdb/eval.c | 1 - > gdb/exec.c | 3 +- > gdb/expprint.c | 1 - > gdb/f-exp.y | 5 +- > gdb/fbsd-nat.c | 2 +- > gdb/findcmd.c | 7 +- > gdb/gdb_wchar.h | 4 +- > gdb/gnu-nat.c | 3 +- > gdb/gnu-v2-abi.c | 3 +- > gdb/go-exp.y | 9 +- > gdb/go-lang.c | 3 +- > gdb/go32-nat.c | 1 - > gdb/guile/scm-cmd.c | 1 - > gdb/i386-tdep.c | 25 ++- > gdb/ia64-linux-tdep.c | 5 +- > gdb/infcmd.c | 7 +- > gdb/infrun.c | 3 +- > gdb/language.c | 1 - > gdb/linespec.c | 19 +- > gdb/linux-fork.c | 3 +- > gdb/linux-nat.c | 1 - > gdb/linux-tdep.c | 17 +- > gdb/linux-thread-db.c | 1 - > gdb/location.c | 17 +- > gdb/main.c | 3 +- > gdb/maint.c | 5 +- > gdb/mi/mi-cmd-break.c | 3 +- > gdb/mi/mi-cmd-stack.c | 2 - > gdb/mi/mi-cmd-var.c | 3 +- > gdb/mi/mi-main.c | 1 - > gdb/mi/mi-parse.c | 11 +- > gdb/minsyms.c | 2 - > gdb/minsyms.h | 2 +- > gdb/nat/linux-osdata.c | 15 +- > gdb/netbsd-nat.c | 2 +- > gdb/objc-lang.c | 13 +- > gdb/or1k-tdep.c | 1 - > gdb/p-exp.y | 17 +- > gdb/p-lang.c | 1 - > gdb/p-typeprint.c | 5 +- > gdb/parse.c | 1 - > gdb/ppc-linux-tdep.c | 13 +- > gdb/printcmd.c | 1 - > gdb/probe.c | 3 +- > gdb/procfs.c | 5 +- > gdb/producer.c | 4 +- > gdb/python/py-mi.c | 6 +- > gdb/python/py-micmd.c | 4 +- > gdb/python/py-objfile.c | 2 +- > gdb/python/python.c | 1 - > gdb/record.c | 9 +- > gdb/remote-sim.c | 1 - > gdb/remote.c | 7 +- > gdb/riscv-tdep.c | 5 +- > gdb/rust-lang.c | 3 +- > gdb/s12z-tdep.c | 2 +- > gdb/s390-tdep.c | 4 +- > gdb/serial.c | 3 +- > gdb/solib-rocm.c | 6 +- > gdb/stabsread.c | 7 +- > gdb/stack.c | 4 +- > gdb/stap-probe.c | 23 +-- > gdb/symfile.c | 3 +- > gdb/symtab.c | 17 +- > gdb/thread.c | 5 +- > gdb/tid-parse.c | 7 +- > gdb/top.c | 1 - > gdb/tracectf.c | 1 - > gdb/tracepoint.c | 6 +- > gdb/tui/tui-layout.c | 7 +- > gdb/tui/tui-win.c | 3 +- > gdb/tui/tui-winsource.c | 3 +- > gdb/typeprint.c | 5 +- > gdb/unittests/command-def-selftests.c | 4 +- > gdb/utils.c | 47 ++--- > gdb/valprint.c | 1 - > gdb/value.c | 5 +- > gdb/windows-nat.c | 6 +- > gdb/xcoffread.c | 1 - > gdb/xml-support.c | 5 +- > gdbserver/gdbreplay.cc | 1 - > gdbserver/linux-low.cc | 3 +- > gdbserver/remote-utils.cc | 7 +- > gdbserver/server.cc | 9 +- > gdbserver/thread-db.cc | 3 +- > gdbserver/tracepoint.cc | 3 +- > gdbsupport/common-defs.h | 6 + > gdbsupport/common-utils.cc | 21 +- > gdbsupport/gdb-safe-ctype.h | 49 ----- > gdbsupport/pathstuff.cc | 2 +- > gnulib/configure | 25 +-- > gnulib/import/Makefile.am | 7 + > gnulib/import/Makefile.in | 33 ++- > gnulib/import/c-ctype.c | 21 ++ > gnulib/import/c-ctype.h | 366 ++++++++++++++++++++++++++++++++++ > gnulib/import/m4/gnulib-cache.m4 | 2 + > gnulib/import/m4/gnulib-comp.m4 | 3 + > gnulib/update-gnulib.sh | 1 + > 137 files changed, 828 insertions(+), 561 deletions(-) > --- > base-commit: c2729c37f10af09126b2916215cae425ae724f55 > change-id: 20250805-gnulib-c-ctype-1b8fb88a6c5e > > Best regards, -- Cheers, Guinevere Larsen It/she