From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZMNoHn0pdGDEDAAAWB0awg (envelope-from ) for ; Mon, 12 Apr 2021 07:05:33 -0400 Received: by simark.ca (Postfix, from userid 112) id 6F1461F104; Mon, 12 Apr 2021 07:05:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8DBF41E789 for ; Mon, 12 Apr 2021 07:05:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E05EF3894C39; Mon, 12 Apr 2021 11:05:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E05EF3894C39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1618225530; bh=XPR4iwyqf2PyuvYD3jzNd/UljOHbTu7/SRgy+FlJ97M=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=FC9AXdHga9o5mzlOAQE7g4wYPEpytUaBO3FKRT+d+B4BwYT5TtwEI4DEozLNyk7dm QFaPTOmkoQReU/bHbMxx25GO4QUpDmNhxXDWK3PbQA4HX2VnIlWL5aR2RmcKTYRUtG 8WsPdDgr9llZVlCz/w5Fh/SUFBZaLOaXOCMkdunM= Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by sourceware.org (Postfix) with ESMTPS id 36D043894C39 for ; Mon, 12 Apr 2021 11:05:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 36D043894C39 Received: by mail-qv1-xf2e.google.com with SMTP id bs7so5497882qvb.12 for ; Mon, 12 Apr 2021 04:05:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XPR4iwyqf2PyuvYD3jzNd/UljOHbTu7/SRgy+FlJ97M=; b=CmICf/FBqfSbYZhgX+ru9RiD4ITj3fusd0LTvpzrLU60XJQM9MdpLZgmj6fBEJKWoT vdE28pwpYRdU4p3nJ3GZgnO8uB2My/xV6Mp8hO1o8wiTCr1kLWv+3Mftq6lItlhl9CFm DrNPlp5yVNRDtjHr7BEpH6JxsXGtJAyBAepcaJnktpn26fwL6ybUce0EnIA2Xc99+EEt xTY5LZbeKXg7Vp9qQl5i4sS5eydRovugqcBumSMT8kvC64R/1lJgMDjpG3eDmshtkAyE B9MRmJpC8Z7D9CuGxPHfEdbr3EecE7vrgL+xRA09P6xcp8a58bgljXWfEl9fkTB46R0s SVyQ== X-Gm-Message-State: AOAM532+lD/Ck44a32av4Dobrm/LvXQjZPlIpVoS5OPTPRF7pAQAGhCZ cO7As5t8BzTnN5+gp0PeQj1lcc/IgJguzQ== X-Google-Smtp-Source: ABdhPJw2xLbK/n35eKIILwS112nNtarLj42WMDI5a75xGfKQooSkgh8lBxeOmjxvfOPipyJzXSCFrg== X-Received: by 2002:ad4:58b0:: with SMTP id ea16mr7891157qvb.45.1618225527780; Mon, 12 Apr 2021 04:05:27 -0700 (PDT) Received: from ?IPv6:2804:7f0:4841:2841:bdd4:355d:8be9:6e9f? ([2804:7f0:4841:2841:bdd4:355d:8be9:6e9f]) by smtp.gmail.com with ESMTPSA id t198sm3647002qke.44.2021.04.12.04.05.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Apr 2021 04:05:27 -0700 (PDT) Subject: Re: [PATCH] gdb, testsuite, btrace: relax unneeded stepi expected output To: "Metzger, Markus T" References: <20210316092637.935739-1-markus.t.metzger@intel.com> Message-ID: Date: Mon, 12 Apr 2021 08:05:23 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Cc: "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, On 4/12/21 5:22 AM, Metzger, Markus T wrote: > Hello Luis, > >>> @@ -51,7 +51,7 @@ gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport >>> # Create a record, check, reconnect >>> with_test_prefix "first" { >>> gdb_test_no_output "record btrace" "record btrace enable" >>> - gdb_test "stepi 19" "($hex in .* from .*|$hex\t$decimal.*)" >>> + gdb_test "stepi 19" ".*" >>> >>> gdb_test "info record" [multi_line \ >>> "Active record target: .*" \ >>> >> >> Investigating some racy tests under make check-read1, isn't there a >> better matching pattern that we can use here to prevent future >> non-determinism? > > The test now ignores all output since it doesn't really matter where we end up > after stepping. This should be the most future-proof pattern. Were you looking > for a less lax pattern? Yeah, I was looking for a more meaningful kind of test other than expecting anything. In any case, I was worried about possible races in the test... > > I ran gdb.btrace with check-read1 on IA and didn't find any issues. ... and since you verified it with read1, I guess it should be fine. Thanks, Luis