From: "Steve Ellcey " <sellcey@mips.com>
To: <gdb-patches@gcc.gnu.org>
Subject: [patch, sim] Fix simulator Makefile
Date: Fri, 22 Nov 2013 20:00:00 -0000 [thread overview]
Message-ID: <b1e01836-18de-4a05-ab77-11f60b47b3cf@BAMAIL02.ba.imgtec.org> (raw)
I am trying to build a complete 32 bit toolchain, including the simulator,
on an x86-64 Linux box by setting CFLAGS and CXXFLAGS to '-O2 -g -m32'.
I ran into a problem when building the simulator because in the igen
subdirectory make is using -m32 when compiling the objects that go into igen
but not on the link line.
I tried setting LDFLAGS to -m32 but that did not help. I noticed that a
number of other targets in that Makefile (that no longer appear to be used)
use $(BUILD_CFLAGS) as well as $(BUILD_LDFLAGS) when linking. Making that
change when building igen fixed the problem.
This may be considered an obvious fix, but I thought I would send it out
first anyway just to double check.
OK to checkin?
Steve Ellcey
sellcey@mips.com
2013-11-22 Steve Ellcey <sellcey@mips.com>
* igen/Makefile.in (igen): Use BUILD_CFLAGS in link.
diff --git a/sim/igen/Makefile.in b/sim/igen/Makefile.in
index 7b2375c..8f6a42c 100644
--- a/sim/igen/Makefile.in
+++ b/sim/igen/Makefile.in
@@ -117,7 +117,7 @@ IGEN_OBJS=\
gen.o
igen: igen.o $(IGEN_OBJS)
- $(CC_FOR_BUILD) $(BUILD_LDFLAGS) -o igen igen.o $(IGEN_OBJS) $(LIBIBERTY_LIB)
+ $(CC_FOR_BUILD) $(BUILD_CFLAGS) $(BUILD_LDFLAGS) -o igen igen.o $(IGEN_OBJS) $(LIBIBERTY_LIB)
igen.o: igen.c misc.h filter_host.h lf.h table.h ld-decode.h ld-cache.h ld-insn.h filter.h gen-model.h gen-itable.h gen-icache.h gen-idecode.h gen-engine.h gen-semantics.h gen-support.h gen.h igen.h
$(CC_FOR_BUILD) $(BUILD_CFLAGS) -c $(srcdir)/igen.c
next reply other threads:[~2013-11-22 19:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 20:00 Steve Ellcey [this message]
2013-11-25 7:49 ` Mike Frysinger
2013-11-25 8:15 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1e01836-18de-4a05-ab77-11f60b47b3cf@BAMAIL02.ba.imgtec.org \
--to=sellcey@mips.com \
--cc=gdb-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox