From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88512 invoked by alias); 21 Aug 2017 10:12:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88482 invoked by uid 89); 21 Aug 2017 10:12:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=transfer X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Aug 2017 10:12:38 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CFABEC05689D; Mon, 21 Aug 2017 10:12:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CFABEC05689D Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 26BEE5D97E; Mon, 21 Aug 2017 10:12:35 +0000 (UTC) Subject: Re: [RFA 2/2] Change install_breakpoint to take a std::unique_ptr To: Tom Tromey , gdb-patches@sourceware.org References: <20170820135402.1213-1-tom@tromey.com> <20170820135402.1213-3-tom@tromey.com> From: Pedro Alves Message-ID: Date: Mon, 21 Aug 2017 10:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170820135402.1213-3-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00372.txt.bz2 On 08/20/2017 02:54 PM, Tom Tromey wrote: > @@ -8540,8 +8540,10 @@ init_catchpoint (struct breakpoint *b, > } > > void > -install_breakpoint (int internal, struct breakpoint *b, int update_gll) > +install_breakpoint (int internal, std::unique_ptr &&arg, int update_gll) > { > + breakpoint *b = arg.release (); > + > add_to_breakpoint_chain (b); I think we should defer .release() until the ownership transfer actually happened, for stronger exception safety. I.e., either: add_to_breakpoint_chain (arg.get ()); breakpoint *b = arg.release (); or change add_to_breakpoint_chain to take an rvalue-ref unique_ptr too, and return the raw breakpoint, and then write here: breakpoint *b = add_to_breakpoint_chain (std::move (arg)); Some spots were/are already only doing the release after adding the breakpoint to the chain, but not all. See e.g., set_raw_breakpoint. The latter approach is my preferred for enforcing the pattern. Otherwise both patches LGTM. Thanks, Pedro Alves