From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Z9jpAYuWLmWZWzAAWB0awg (envelope-from ) for ; Tue, 17 Oct 2023 10:13:31 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=I3iQm9iL; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id ED60F1E0C1; Tue, 17 Oct 2023 10:13:30 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D6B9C1E00F for ; Tue, 17 Oct 2023 10:13:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 52B173858C54 for ; Tue, 17 Oct 2023 14:13:28 +0000 (GMT) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2049.outbound.protection.outlook.com [40.107.101.49]) by sourceware.org (Postfix) with ESMTPS id 1910E3858C52 for ; Tue, 17 Oct 2023 14:13:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1910E3858C52 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1910E3858C52 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.101.49 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697551997; cv=pass; b=HTaCZwwvfbR7VgKDvlpbn7O+fhy96NK/uu1L0tWN2MPkUaU6OIs7kK7edi6/zpkqrWMKe6ybPuKLI8h+Njt0CSVyhIKcyJeVCOVTEoAd72n+Jq/I0e4rlQojTrboMYPR3hnqFO9TTPIZFnOa+iwGXZiFtcsU/4oPjMG3t1Rxbzo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697551997; c=relaxed/simple; bh=GpaGYaPTlaY8AYMWoB2n/R1lqoRPZRBsofmdaxdw0Po=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=LMTsXXWnfXBooJ6n71aoN3y00IoNxsRhnv95vKqAHPwRPRQOUgCIcC11XVgXIVETQUD4rSfXyNNAZ0xXLQ5H0Sbj6b7z078FqjPbir68WihzVOAkmLZV8o8He6hLcdIQjJJXJ/6z29VTOp3xzHKhh5TRQKTeapruIdt7dzNEu48= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gqEaL0JbyaoAXpN2RMoWM/F36xKuIweZCeYS1rZ7CpSaGoSCn+StpCaCdNVwEfVgxKzkVz/jUZjZzVH7M5flNlCk0U8DooypQDdb/AjR6UHFedKuNx6ykAS1BKDr1Gr/eIfvQCkHYtUKM6IuZl53F5ZYca1TaRUxYf2cprQoPXM6HkVyFfQN9v4Kwo9KTy7QIdNPFcvgYYsYDMuZFDv4zlCwR6Pw9YH5X12esiY0mYSQO88WNNXDrYbCQYo+U6vavyoiVf+WR1kxAUfCCTHRLbY2u7m05GTsK/pZFJFPBBmekrt7sHnW8LNJTeHlXOxajPH8dFw8UWBftPKGIZUCXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jh7kCCPMH4OtHvcmRf8OgjIEp5859zq9G7mBjQVgQy8=; b=bbQFBOVyb00RqHCg/J7v5pN6EhTgHqlc8QFzjTGMUgr5HpCd33NOJ9SEurph7jxEuca/00atHFbMFLSXSR9siMSj4geuZr/xqX3zOw/cVjnwVqkvtd9YtyrI7PzVmcUX0Et+52SfgQyZ+XL9tNjHw1lqi/4TQV/NSAZ1k60W9B0glApO+StIrqfDs1rY3O5PtwXSaeThQQCpmhEn4FfCreK8IlK8Db5CGc+8UDNKK1Fm+6K6/kJbTLjad00SvDrS5WpP7nG2r/J03hTACrWzn3NaCJOhzI29rTlgwoukO7FXGdPa7+yp9QPNbqCL/RCqhJEmxKy/ph/0IF/J6aA7lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jh7kCCPMH4OtHvcmRf8OgjIEp5859zq9G7mBjQVgQy8=; b=I3iQm9iL46KxOmgtBIelWlAAJ6RQuDVknP8npSCgSBBpU/O/idAF/Vt1Qw6nOJkWvsuuhxGkI/8dkGWhtTaSd3ikwbsqLmb9xt6W3l+R+wGr5vdRsWEJTeFs1oImuV1FE3jDxyq9LBfq/8yGSJeim+uIcezIpJaPg7PqHNNk9pY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by SA1PR12MB7200.namprd12.prod.outlook.com (2603:10b6:806:2bb::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Tue, 17 Oct 2023 14:13:12 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::3120:8014:c770:9f8f]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::3120:8014:c770:9f8f%7]) with mapi id 15.20.6863.047; Tue, 17 Oct 2023 14:13:12 +0000 Message-ID: Date: Tue, 17 Oct 2023 15:13:07 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/11] gdb: Use std::string_view instead of gdb::string_view Content-Language: en-US To: Pedro Alves , Tom Tromey Cc: gdb-patches@sourceware.org References: <20231013144418.3180617-1-lancelot.six@amd.com> <20231013144418.3180617-7-lancelot.six@amd.com> <87il78x49e.fsf@tromey.com> <87zg0iqs1p.fsf@tromey.com> From: Lancelot SIX In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0174.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::17) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|SA1PR12MB7200:EE_ X-MS-Office365-Filtering-Correlation-Id: 294eb2db-57db-4035-65e3-08dbcf1b32b7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qwN23aThtDsjRrUubkLwkqwkIe4avTQGa9verbJ4rTErTI4yInFgrPjaAuY4DvS/Gs7PjcZfEl+uWmbrBQ3ZYIriXMIxJgES2tft9YiX5TAVcBxchZLftBHVjJcrLh1T4YmwTFDiQ6L+BDqEvjB47bAP+OGrDjsjUJxpne7z8B2Sz4ior8EWJkpHuNYdYVgLKJ7tYmhTl5V3bdkywXz4uW6cpQCee7MWNuRKgZmNjAHHLeHq830P38H1suter711Ts8qTJIFWvy/tj4Yj/b5+eXoTKR6S/Ij1y9WytKeDKA3LwLevkwwK1eFE7raEGz7EfsZXjNf0FwlKnxNS4SyJGfLBhNsdsPTGUAl1oSGFUa5WP2iF3wP4VplmUvk27iFgcJS0E89bIFyk6Ltwuv67w/M13eevvlEJiF+tRF6C959WBJ55ba4IdbPrjw4TkCggjzIaNjoYO+nRX2E9oPnngE3I3zX5IN2RJfzptYALPSvHz/3bwb495cdEvmpcPYlfmoQ+cxgbIrztGsEWk4UZPkw9TIG+OVMbqv28rjNRuSKW7Gfx8b4xDWO7iZJR/Nf777ulksxu8Ltsu1953LVYdSSl4oxT+xyOmzgBn2W22ReZHNMdnX2du6xwOQeBab820KjFD9vXiroPPlgciPIXg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(346002)(136003)(366004)(39860400002)(230922051799003)(64100799003)(1800799009)(186009)(451199024)(6506007)(26005)(36756003)(66946007)(66556008)(66476007)(316002)(110136005)(31686004)(6512007)(53546011)(2616005)(38100700002)(86362001)(31696002)(6486002)(2906002)(6666004)(478600001)(5660300002)(8936002)(4326008)(8676002)(41300700001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWtkYkxaQTJENlJUUHJEYzF4TU14YlArV2w5aDZVdTg5UklnK2pUZ0ExOVJl?= =?utf-8?B?aUYyVDFlSVNOUTlEYXQyOGM1TXMxRDF4d2JCUXNHSlNQSm1BTlRLU21vbkJU?= =?utf-8?B?Z3ltN092RkY0alhmUHBpZVo1aEhOMVk1VGErbHRndDBia2hQbG1rc3ZtVHNT?= =?utf-8?B?QkVPZDJnL1FWbnJLcmp6UE5uTXFZOS9wV1ZaWnBRMFZNa2U3aGxNemU1djVT?= =?utf-8?B?cy9yQ2J4MGdVSXRua0VrTWtVLzJ1emFvNm93cTlTZ3BxcW1TTTdMS3hqOFRa?= =?utf-8?B?VjhpYjcrTld5U1pFY3c0aVR1RVVwYVZsZ1ozMWVlVmhaOHAyTS82TWp5dDFu?= =?utf-8?B?NXIyNk41YWlSbG5ZMnI1YlMyakczNGFsNXY2ZG9vQlNralFsSU1uM2ZGcERj?= =?utf-8?B?WHg1WmhoNkVRczJuQnJoYW40aUJEK1pxS0c0U29IaE5Cdk9CTS9sdDF6QW54?= =?utf-8?B?eFFXWFYzNTd6TGZPZ21LQUplTlNRZXUxTi9haUtKWjVEbHhhZHNJNUN4Qy9P?= =?utf-8?B?RFIxWEh1Y3NyRzhRWTFFdTFnaGZpNWd4dzlLTWRMZEQwTGY2aUxWU3UrYkpX?= =?utf-8?B?RUlwRzFPcjFTZ2dCL3dUN2VEUEc5MHJVeVBTZFVCQ2VEQVgvVjUvZVdsTjVF?= =?utf-8?B?RDZtL2prSGt0R0ZXZE0yeVljNnlzYklTM0JWWkw3NFIyVHRQeUpLWFJqRWk0?= =?utf-8?B?VElRNG8wWG52bDN5V2JER3E1a3pJOGpldG9BWlZVd0ZrdGhmUXVCVUgxZWpZ?= =?utf-8?B?T1gzdmFoSU84VWFQYnRyS3BTZTVYOFZRdncxYW9maGhMMW8rdTlaQUJwV1Q5?= =?utf-8?B?TWZZRUVreU1qcHZzSVJpQUI2UjFIaDdPNmc0VHpEQVlVWjBKWEdjKytLODdi?= =?utf-8?B?TUxxcjIrTWwzeWF5eFJLZXI3cnFiNXJKby9vNmRoWFZNdnpZVktPV2xVNjBY?= =?utf-8?B?dGI1Ylc4N0JvNzE3cTdYK0swN3NjMnpQYWRqd3FhaElPTWJhYU13Z0hDUTIr?= =?utf-8?B?d3JjZUhPWk5VQ2txNm5EZmRqcU5SRHhuUi9qSWpxc0pFY28rS25STjBubFBX?= =?utf-8?B?bWF4ODQvY1UxMnFoaVNsdktYUUlFZ2ZMRWdEbjZTQVhEV0FRZ0xlTjN0eGpq?= =?utf-8?B?a2NPclJ2WjM0dXZDSmNNd1I0bUJIL015VFhBTjNVanRIMTZUUlJVTU5DMVpi?= =?utf-8?B?dTVORFFUNy9idm9MNEp5N2VBNmgvRzNOU1B0bFVxeFQ0VEh6TGxrcURoVU9Z?= =?utf-8?B?b08zWUREVG5vdVA5OGVVU0tCWTFvWStaVnQxZmgvOUhTNmFJOG5KVElUM0RY?= =?utf-8?B?ejZ1Zm5MMEZOUkJnK0FPdklxMTZoYXZ1ZnllQkJWaXVSYkNlRitObDVqaEpp?= =?utf-8?B?OFVXREEwRnZTUlQ2c2Fac3JGS0RmRmRLc3lVNWp2bFJBQ1VJMW1nVllSU0VE?= =?utf-8?B?aTN2RzZxcjlGbzQ5TlVLdE1LeE5PbXh1SUFSejRtZC9jdVU4ZTdwTlNhR2Rv?= =?utf-8?B?REJkdnNkTTJjUWJNa0t0Q3IrRkxCeW9Gckpkam9Hdm1zbS9mL2ZXREVObUs2?= =?utf-8?B?YzVZKzFhcHBLdUtxTXpPdkIrNFFsdVBPS0NpY0pkQTVER2REMUVlbTRIVXNR?= =?utf-8?B?OWlPK1FQOWVSbHIrb0JtckZienhXQkFhVW90N3ltTGRXT01JN3VWZ3FJdHFw?= =?utf-8?B?ZEJKc3dFRXVBaFMrUmxDR2ZicDNQTkhkaFRlZXFqWmVJdUg5bGk2N3o1bWtZ?= =?utf-8?B?YzVyTDhwaTE1OUpJcUJ6MGNmVDVBenVZSUloTlVweEJLU2FuY3hQcnUzL2R2?= =?utf-8?B?ZFQ0UGZBbXZxZk1JSy9qL2tiNE8zSDE2NFVaOUowWXdubWtKSWxFTUY4VTFR?= =?utf-8?B?OWNLUy9Gdk5UVXpwNm02M25NRDdMdWtqbkdXQkdKSnhlZ3cyVGFzRmt4RVA1?= =?utf-8?B?aUhnamNPU3Y5eHJTajNQUlUxVHNTcFI5V3duRzVPYjRFQkdRTUk3V09VQWxO?= =?utf-8?B?ck92bkRLcFZsem13UFdCYjZtZzhHSG1iUlphMDhiemZGVmNrS0NENEtKNHpH?= =?utf-8?B?UUU3dTBPY2x2VnpGU2Z2SDYrbVdScmVjZXp1SGJudnZsY0Ixd1VJYUlqWWNI?= =?utf-8?Q?tXoa3rUWDJkR9LoELWlPSNlmL?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 294eb2db-57db-4035-65e3-08dbcf1b32b7 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 14:13:12.6857 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9E+dNV96TvGHTjfOEOMbsVHkGCVXtXUtZNkJB998PC6NI6pnpHHqQiiryHMA6kWBqPNpOZdAhoZtX//6QJ7Grg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7200 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Hi, On 16/10/2023 22:51, Pedro Alves wrote: >> Lancelot> + std::string_view name; >> Lancelot> + if (const char *name_str = keyname (ch); >> Lancelot> + name_str != nullptr) >> >> We should probably discuss whether to allow this construct before >> letting it in. >> >> Personally I'm ok with it. > > I think it may look a little weird if you're not used to it (like I am not), but > OTOH it isn't really different from introducing a variable to scope with "for", like: > > for (const char *name_str = keyname (ch); > name_str != nullptr; ....) > .... > > so I suspect we'll all just get used to it and think nothing of it in a few years. > > So am I fine with it too. > I don't mind not using this for now. The "name_str" will be declared outside of the if scope for now. If this construct is comes in, there will also be the question of coding style (i.e. single line if line length permits or multiple lines as I did here). I guess we could go the same way we do for "for" and prefer single line. Best, Lancelot.