From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EV6HI3Y5hml1kSwAWB0awg (envelope-from ) for ; Fri, 06 Feb 2026 13:56:54 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=SbyBU37E; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8E5961E0BA; Fri, 06 Feb 2026 13:56:54 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0651A1E08D for ; Fri, 06 Feb 2026 13:56:54 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 86FE64BAD15A for ; Fri, 6 Feb 2026 18:56:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 86FE64BAD15A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=SbyBU37E Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 0AFE54BA23FE for ; Fri, 6 Feb 2026 18:56:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0AFE54BA23FE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0AFE54BA23FE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770404188; cv=none; b=Jr+XAnRlEpA9euHKBr8e9zthLC/uOcXmPJuS/MF5Nygzw2RBy2+duG55ponSsrBY8b4o/tuRsP1VpOi/IYXVwTVb9BRf9JXs3tVyeZLwo1cFP+YjfHrUflrqzCavngCxeWqtTVjnrwpDsQWhpdP+j/8FOgKmzYBic0KeEgWy2kw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770404188; c=relaxed/simple; bh=v1PaKvYb/zfINJkFgLSkOwCsPasrPRXJpJIcpslHjE0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=aBGFj0BsymT1A6hqKvF9Hy5h4OFB1lDm314LjzZb36TUsOdbJip39BmbMk1ouBGTqSUpM8ISEm2oyVnnYzJ7QtArqe4sNIuShzYC+fFrdxI7OToPd2KWSYOVDoZEIQgWj7eVzHe7L2J62UaVUGLU3RLJoXmU0Sjoj9YDmO3ZDHQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0AFE54BA23FE Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 616IuJV8079688 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 6 Feb 2026 13:56:24 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 616IuJV8079688 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1770404184; bh=FvqCKswtN84zuE+NdYcXnecUiMOUGV6QbOsf6eRGVm8=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=SbyBU37Eisz4XLSqHwjIFzFCAhvsrpmZqZwh6rTmA/THpuXGF5qdG6ifftXqxb0cR VAF7eQFkAPFxSMjjvgKWmiQEiqATKq/mrlzO6ueHNe/GbfN31UdMlxRAA0Yxjyap1n CI3lBovRDMaFvAUa3V72zxIaFCLGIvLp931kkJ4ux97kmUW7381MzjNvuxpBh4VbHK 0hcKWCOh/hxntnaM+nl6tn4pKqSOU05kwCJr888IVtKrCLVM7YKRAq3/47XJr8rl2h dSMzPsePKBk1gUE2PWBwEJ6KxRKf7/vzO1cKcRxYUwRkCnmwMgMfSZtb6asoukGhDX uXwXCjFQGFcLA== Received: by simark.ca (Postfix) id 2EB611E08D; Fri, 06 Feb 2026 13:56:19 -0500 (EST) Message-ID: Date: Fri, 6 Feb 2026 13:56:18 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb/block: remove block_iterator::d::block, remove union To: Guinevere Larsen , gdb-patches@sourceware.org Cc: Simon Marchi References: <20260206025238.3467043-1-simon.marchi@polymtl.ca> <34266c62-3b55-4718-8eed-d5003862c55e@redhat.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <34266c62-3b55-4718-8eed-d5003862c55e@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 6 Feb 2026 18:56:19 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-02-06 11:08, Guinevere Larsen wrote: > On 2/5/26 11:52 PM, simon.marchi@polymtl.ca wrote: >> From: Simon Marchi >> >> The block field is never used. The block is only used to grab a >> reference to the mdict, which is stored in the mdict_iterator. >> >> Remove it and remove the union. Leave the compunit_symtab field, whose >> name unfortunately conflicts with the method. >> >> Change-Id: I09dbc42f937eaba6c70598acca8ff355c4e5bdb9 > > This change looks harmless enough, but since I don't feel like I understand it well enough to properly review, best I can say is, no issues running the testsuite or rebuilding, so > > Tested-By: Guinevere Larsen Thank you for checking. Simon