From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58716 invoked by alias); 23 Sep 2016 16:07:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58663 invoked by uid 89); 23 Sep 2016 16:07:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=bother, ending, mass, learn X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Sep 2016 16:07:38 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 34FA1C0528A3; Fri, 23 Sep 2016 16:07:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8NG7Ymn015369; Fri, 23 Sep 2016 12:07:34 -0400 Subject: Re: [PATCH] gdb: Replace operator new / operator new[] To: Yao Qi References: <1474543227-19614-1-git-send-email-palves@redhat.com> Cc: "gdb-patches@sourceware.org" From: Pedro Alves Message-ID: Date: Fri, 23 Sep 2016 16:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-09/txt/msg00310.txt.bz2 On 09/23/2016 10:44 AM, Yao Qi wrote: > On Thu, Sep 22, 2016 at 12:20 PM, Pedro Alves wrote: >> diff --git a/gdb/common/new-op.c b/gdb/common/new-op.c >> new file mode 100644 >> index 0000000..c3b73c1 >> --- /dev/null >> +++ b/gdb/common/new-op.c >> @@ -0,0 +1,85 @@ >> +/* Replace operator new/new[], for GDB, the GNU debugger. > > Patch is good to me. Thanks much! > One comment on file name suffix, did you consider > .cc suffix? > I think that if we want to use .cc, it should be a mass rename across the board. Ending up with a mix of .c and .cc files when both extensions are C++ file is much more confusing than all C++ files named .c, IMO. gcc didn't do it, but I think that was because of that making it difficult to do archaeology. I don't think we have that problem with git, as it can cross renames. .c files don't bother me, but maybe it'd be one less little detail newcomers would have to learn. Not sure... Thanks, Pedro Alves