Re: [PATCH v2 04/25] Introduce interpreter factories

Yao Qi
2016-03-22T08:55:59Z

Pedro Alves <palves@redhat.com> writes:

> +void
> +interp_factory_register (const char *name, interp_factory_func func)
> +{
> + struct interp_factory *f = XNEW (struct interp_factory);
> +
> + f->name = name;
> + f->func = func;
> +
> + /* FIXME: assert that no factory for NAME is already registered. */
> + VEC_safe_push (interp_factory_p, interpreter_factories, f);
> +}

It shouldn't be hard to do the assert here, and get rid of the FIXME.

--
Yao (齐尧)