Re: [PATCH v2 00/25] Towards great frontend GDB consoles

Pedro Alves
2016-05-06T11:58:09Z

On 03/22/2016 10:41 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> This still misses ChangeLog entries, some comments, and documentation
>> changes. And I haven't thought about tests yet.
>
> I go through the patches, and give my comments.

Thanks much!

> They look pretty good!
> We need to think about the tests.

So for v3, I added a way to run the whole testsuite with
MI running in a separate UI, by passing:

make check RUNTESTFLAGS="FORCE_SEPARATE_MI_TTY=1"

That was quite convenient and caught a few issues, all of
which I resolved for v3.

In addition, I made it possible for the tests themselves
to easily start with MI on a separate UI. So some of the
new patches in v3 come changes to testcases to make them
run with both MI running in the main UI and as separate UI.

All in all, I'm pretty confident with v3 now. I'll post it
soon.

Thanks,
Pedro Alves