From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82239 invoked by alias); 6 May 2016 11:50:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82216 invoked by uid 89); 6 May 2016 11:50:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 06 May 2016 11:49:57 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7A3663B726; Fri, 6 May 2016 11:49:55 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u46Bnsfd031206; Fri, 6 May 2016 07:49:54 -0400 Subject: Re: [PATCH v2 22/25] Make main_ui be heap allocated To: Yao Qi References: <1458573675-15478-1-git-send-email-palves@redhat.com> <1458573675-15478-23-git-send-email-palves@redhat.com> <86k2kuvmy3.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 06 May 2016 11:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <86k2kuvmy3.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00093.txt.bz2 On 03/22/2016 10:14 AM, Yao Qi wrote: > Pedro Alves writes: > >> --- >> gdb/event-top.c | 7 +++---- >> gdb/main.c | 27 ++++++++++++--------------- >> gdb/top.c | 37 +++++++++++++++++++++++++++++++++++++ >> gdb/top.h | 5 +++++ >> 4 files changed, 57 insertions(+), 19 deletions(-) >> >> diff --git a/gdb/event-top.c b/gdb/event-top.c >> index 436edf7..69f6be7 100644 >> --- a/gdb/event-top.c >> +++ b/gdb/event-top.c >> @@ -362,11 +362,10 @@ top_level_prompt (void) >> return xstrdup (prompt); >> } >> >> -static struct ui main_ui_; >> >> -struct ui *main_ui = &main_ui_; >> -struct ui *current_ui = &main_ui_; >> -struct ui *ui_list = &main_ui_; >> +struct ui *main_ui; >> +struct ui *current_ui; >> +struct ui *ui_list; > > We need comments to "main_ui" and "current_ui". I am carrying a > question "what is the main UI" since patch 06. Good point. I've added comments in v3. Thanks, Pedro Alves