From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-148826-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 92249 invoked by alias); 8 Jul 2018 17:08:50 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 92236 invoked by uid 89); 8 Jul 2018 17:08:50 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 17:08:49 +0000
Received: from [10.0.0.11] (unknown [192.222.164.54])	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))	(No client certificate requested)	by simark.ca (Postfix) with ESMTPSA id 88E701E059;	Sun,  8 Jul 2018 13:08:47 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail;	t=1531069727; bh=HzTRJaHthVuTOrA6PSnNXTtNDWfSG3lUvMq36mgP7ns=;	h=Subject:To:Cc:References:From:Date:In-Reply-To:From;	b=IZZoX3No7F3Sgg08ku8i4ZP6VVxxqysASFtugyJFu0bzKhzHC5FPDhOcgkDo6/Z4k	 Y1AsE6vkDFBxCmhQx0ftEGlwPLaouSCCYqqadKhMX21eWCYAugUx6tLIpoIOMj86qa	 W6cXTN/2ERlOTfljuPYbANtBV3hi7XXGdjWd/qco=
Subject: Re: [RFA 19/42] Move the using directives to buildsym_compunit
To: Tom Tromey <tom@tromey.com>, Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-20-tom@tromey.com> <cae07bf5-017f-b027-1f13-e15391827857@redhat.com> <87efgd66ao.fsf@tromey.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <b100fee7-6d98-6be6-7409-0254aac6e7e0@simark.ca>
Date: Sun, 08 Jul 2018 17:08:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <87efgd66ao.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-07/txt/msg00206.txt.bz2

On 2018-07-08 12:28 PM, Tom Tromey wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
> 
> Keith> Since you're modifying these lines, could you update the comments
> Keith> (e.g., capitalize "Global") and remove the newline between the
> Keith> comment and decl?
> 
> I did this.
> 
> Tom

LGTM with this.

Simon