Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 3/4] Use new_reference for struct value
Date: Mon, 30 Apr 2018 17:05:00 -0000	[thread overview]
Message-ID: <b0e48111-c897-9164-069a-ecc8f19450de@redhat.com> (raw)
In-Reply-To: <20180430042147.28337-4-tom@tromey.com>

Hi Tom,

The series looks fine to me.  Tiny comment below.

On 04/30/2018 05:21 AM, Tom Tromey wrote:

> diff --git a/gdb/value.h b/gdb/value.h
> index b58f78998a..060cef5639 100644
> --- a/gdb/value.h
> +++ b/gdb/value.h
> @@ -88,12 +88,12 @@ struct value_print_options;
>  
>  struct value;
>  
> -/* Decrease VAL's reference count.  When the reference count drops to
> -   0, VAL will be freed.  */
> +/* Increase VAL's reference count.  VAL is returned.  */

"VAL is returned" is stale here.

Thanks,
Pedro Alves


  reply	other threads:[~2018-04-30 17:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30  4:21 [RFA 0/4] add ref_ptr::new_reference Tom Tromey
2018-04-30  4:21 ` [RFA 1/4] Introduce ref_ptr::new_reference Tom Tromey
2018-04-30  4:21 ` [RFA 3/4] Use new_reference for struct value Tom Tromey
2018-04-30 17:05   ` Pedro Alves [this message]
2018-04-30 17:32     ` Tom Tromey
2018-04-30  4:21 ` [RFA 2/4] Remove new_bfd_ref Tom Tromey
2018-04-30  4:21 ` [RFA 4/4] Change Python code to use new_reference Tom Tromey
2018-04-30 13:34   ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0e48111-c897-9164-069a-ecc8f19450de@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox