From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88664 invoked by alias); 17 Aug 2016 23:13:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88654 invoked by uid 89); 17 Aug 2016 23:13:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*MI:sk:1471468, H*f:sk:1471468, H*i:sk:1471468 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Aug 2016 23:13:17 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C0DC2C057FAC; Wed, 17 Aug 2016 23:13:16 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7HNDFq2021858; Wed, 17 Aug 2016 19:13:15 -0400 Subject: Re: [PATCH] Sync proc_service definition with GLIBC To: Adhemerval Zanella , gdb-patches@sourceware.org References: <1471468737-10208-1-git-send-email-adhemerval.zanella@linaro.org> From: Pedro Alves Message-ID: Date: Wed, 17 Aug 2016 23:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1471468737-10208-1-git-send-email-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-08/txt/msg00181.txt.bz2 On 08/17/2016 10:18 PM, Adhemerval Zanella wrote: > GLIBC BZ#20311 [1] proc_service.h install patch also remove 'const' > attributes from ps_get_thread_area and comment #15 discuss why to remove > the const attribute (basically since it a callback with the struct > ps_prochandle owned by the client it should be able to modify it if > it the case). > > On default build this is not the issue and current g++ does not trigger > any issue with this mismatch declaration. However, on some bootstrap > build configuration where gdbserver is build with gcc instead this > triggers: > > error: conflicting types for 'ps_get_thread_area' > > This patch fixes it by syncing the declaration with GLIBC. > > [1] https://sourceware.org/bugzilla/show_bug.cgi?id=20311 > > 2016-08-17 Adhemerval Zanella > > * gdb/aarch64-linux-nat.c (ps_get_thread_area): Remove const from > struct ps_prochandle. > * gdb/amd64-linux-nat.c (ps_get_thread_area): Likewise. > * gdb/arm-linux-nat.c (ps_get_thread_area): Likewise. > * gdb/gdb_proc_service.h (ps_get_thread_area): Likewise. > * gdb/gdbserver/gdb_proc_service.h (ps_get_thread_area): Likewise. > * gdb/gdbserver/linux-aarch64-low.c (ps_get_thread_area): Likewise. > * gdb/gdbserver/linux-arm-low.c (ps_get_thread_area): Likewise. > * gdb/gdbserver/linux-crisv32-low.c (ps_get_thread_area): Likewise. > * gdb/gdbserver/linux-m68k-low.c (ps_get_thread_area): Likewise. > * gdb/gdbserver/linux-mips-low.c (ps_get_thread_area): Likewise. > * gdb/gdbserver/linux-nios2-low.c (ps_get_thread_area): Likewise. > * gdb/gdbserver/linux-tic6x-low.c (ps_get_thread_area): Likewise. > * gdb/gdbserver/linux-x86-low.c (ps_get_thread_area): Likewise. > * gdb/gdbserver/linux-xtensa-low.c (ps_get_thread_area): Likewise. > * gdb/i386-linux-nat.c (ps_get_thread_area): Likewise. > * gdb/m68klinux-nat.c (ps_get_thread_area): Likewise. > * gdb/mips-linux-nat.c (ps_get_thread_area): Likewise. > * gdb/nat/aarch64-linux.c (aarch64_ps_get_thread_area): Likewise. > * gdb/nat/aarch64-linux.h (aarch64_ps_get_thread_area): Likewise. > * gdb/xtensa-linux-nat.c (ps_get_thread_area): Likewise. OK, but please move the ChangeLog entries to the correct ChangeLog files, and make the entry paths be relative to the corresponding ChangeLog file. gdbserver changes go to gdb/gdbserver/ChangeLog, the rest goes to gdb/ChangeLog. Thanks, Pedro Alves