From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 596D1385DC32 for ; Sat, 30 May 2020 23:59:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 596D1385DC32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4284D1E072; Sat, 30 May 2020 19:59:04 -0400 (EDT) Subject: Re: [PATCH] gnu-nat: Move local functions inside gnu_nat_target class To: gdb-patches@sourceware.org, Thomas Schwinge , thomas@schwinge.name, bug-hurd@gnu.org References: <20200530180459.ixrex5ui7apzpt4u@function> From: Simon Marchi Message-ID: Date: Sat, 30 May 2020 19:59:03 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200530180459.ixrex5ui7apzpt4u@function> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2020 23:59:06 -0000 On 2020-05-30 2:04 p.m., Samuel Thibault wrote: > This allows to have the process_stratum_target object at hand for future use in > the gdb API, and only use gnu_target from external calls. > > gdb/Changelog: > > * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced, > steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup, > inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports, > inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports, > inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread, > inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal, > inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc, > proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port, > proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions > to gnu_nat_target class. > * gnu-nat.c: Likewise. > (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd, > set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd, > set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target > object. > (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this' > instead of `gnu_target'. Thanks, this LGTM, I think it's a good step forward. Simon